search

Bioconductor / packagebuilder

5 stars 7 forks source link

Replace '%s' in code #22

Closed b-long closed 6 years ago

b-long commented 8 years ago

There are a lot of log statements like :

# value is substituted, by parameter order
logging.info("Some info about '%s'." % value)

It'd be more maintainable if we used this approach :

# value is substituted based on key
logging.info("Some info about '{hostname}'".format(hostname = value))

Many of these statements were made when https://github.com/Bioconductor/packagebuilder/pull/18 was merged, to find that bunch: git diff eb96311..98cc540 --name-only | xargs grep -F '%s'

lshep commented 6 years ago

Reviewed with Martin not planning on implementing in near future