search

Bioconductor / packagebuilder

5 stars 7 forks source link

update BiocCheck script calls to use R -e ... #40

Closed LiNk-NY closed 3 years ago

LiNk-NY commented 3 years ago

Hi Lori, @lshep Here is my attempt at updating the SPB builder.py script to use the BiocCheck::BiocCheckGitClone and BiocCheck::BiocCheck. I have not tested this as I am not sure how. Your careful review is appreciated! Thanks!

lshep commented 3 years ago

Actually the SPB code was already updated. The live code still lives in the python3 branch -- we haven't merged it into master yet

LiNk-NY commented 3 years ago

Thanks Lori @lshep ! Does that mean we can go ahead and remove the script installation here https://github.com/Bioconductor/BiocCheck/pull/123?

lshep commented 3 years ago

Should be okay yes. @LiNk-NY thanks for looking at this!!