search

BiodataAnalysisGroup / UMIc

A framework implementing a method for UMI deduplication and reads correction.
MIT License
8 stars 4 forks source link

countsCutoff can't be 1 #4

Open hukai916 opened 1 year ago

hukai916 commented 1 year ago

Hi developers,

When setting countsCutoff <- 1 in the UMIsProject.R (using data/case3), I got the following error message:

Error in setnames(x, value) : 
  Can't assign 3 names to a 2 column data.table

I was able to trace down to the following line: https://github.com/BiodataAnalysisGroup/UMIc/blob/8b9228f19fb8104fe74193c75aa438531db0281c/R/functions.R#L267

If changing UMI12 to UMI, the error was gone. Not sure if this is a potential bug or not.

Let me know,

--Kai

npechl commented 1 year ago

Hi @hukai916,

Thank you for your notice! Indeed that was a minor bug, that has been fixed. We have updated the functions.R script and UMIc should now work properly.

We will keep the issue open for some days. Ιf the error still occurs, please feel free to comment!

Best regards, Nikos

hukai916 commented 1 year ago

ty