Use timezone of vector instead of trying to specify

Biogen-Inc / IDEAFilter

An R Shiny Filtering module. Demo the shiny module at: https://bit.ly/demo_IDEAFilter

https://biogen-inc.github.io/IDEAFilter/

Other

12 stars 2 forks source link

Use timezone of vector instead of trying to specify #21

Closed Jeff-Thompson12 closed 1 year ago

Jeff-Thompson12 commented 1 year ago

Addresses #17

Jeff-Thompson12 commented 1 year ago

@AARON-CLARK Do you know of any reason we wouldn't want to make this change? I believe it is now behaving as expected but wasn't here when this method was being created.

Jeff-Thompson12 commented 1 year ago

@AARON-CLARK Question: Do you think the datetime filter should be representing times corresponding to the time zone of the data or the time zone of the user?

Jeff-Thompson12 commented 1 year ago

Which produces the following table with no data when launching app.R. That makes sense because if I'm currently located in EDT (the day light savings time version of EST). Once I switch the tz above to "EDT", all the data shows up.

In order to view the changes you will have to build the package based on the PR. I think you can also run devtools::load_all(). When you run the app, you should be able to see all the data regardless of which time zone you initialize the datetime field as.

AARON-CLARK commented 1 year ago

Also, did you just answer my question by asking me the same question? 😆 Either way, this PR is ready to go.