search

Biogen-Inc / IDEAFilter

An R Shiny Filtering module. Demo the shiny module at: https://bit.ly/demo_IDEAFilter
https://biogen-inc.github.io/IDEAFilter/
Other
12 stars 2 forks source link

Utilize `moduleServer()` #23

Closed Jeff-Thompson12 closed 1 year ago

Jeff-Thompson12 commented 1 year ago

Addresses #22

Jeff-Thompson12 commented 1 year ago

@AARON-CLARK I don't know if you have any opinions regarding implementing the wrappers. I was going to merge this into devel before working on #6 because I want to use the wrappers in the vignette.

Jeff-Thompson12 commented 1 year ago

This PR goes beyond being a wrapper and is meant to allow more sensible development to continue using a more modern implementation of modules.

One important feature is that IDEAFilter() does not make copies of the data reactive. This in theory should make the filter faster and allow for other implementation options (such as not forcing the water fall structure in place).