Change `pillar::new_pillar_type()` to `pillar::type_sum()`

Biogen-Inc / IDEAFilter

An R Shiny Filtering module. Demo the shiny module at: https://bit.ly/demo_IDEAFilter

https://biogen-inc.github.io/IDEAFilter/

Other

11 stars 2 forks source link

Change `pillar::new_pillar_type()` to `pillar::type_sum()` #9

Open AARON-CLARK opened 1 year ago

AARON-CLARK commented 1 year ago

Change pillar::new_pillar_type() to pillar::type_sum() since the original code is just grabbing the output from type_sum() anyways. Certainly is more efficient coding. See dgkf/shinyDataFilter PR #15

Replace this: https://github.com/Biogen-Inc/IDEAFilter/blob/d216e1e81205fea46aa74630a1adc47eb156019d/R/shiny_vector_filter.R#L142

With this:

type <- pillar::type_sum(obj)
if (length(type) == 0L) "" else type