Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

`R-CMD-CHECK` failing; Need new release on CRAN #155

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago

The CRAN team reached out and notified me that tidyCDISC is failing R-CMD-CHECK as a result of the new release of dplyr for the devel version of R. This was to be expected given #144.

So, we'll have to cut a new release of tidyCDISC . The devel branch only contains 4 changes according to the NEWS file (I'll have to update), but I count these new additions too:

image

Discussion question(s)

I think there are enough changes here to justify a minor release, incrementing from v0.1.1 to v0.2.0. Or do you think a patch release is more appropriate to v0.1.2?

Secondly, we have two outstanding PRs that are "close" to being ready. Do we want to include them now or later? I'm happy to wait, but wanted to ask the PR author's opinions.

Jeff-Thompson12 commented 1 year ago

With regards to #145, I think that should wait for the next release.

tdwils commented 1 year ago

147 still needs some more work, so I would like to wait on that one too.

AARON-CLARK commented 1 year ago

closed with #160