search

Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

Individual Explorer: Guide hangs after last prompt. #201

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago 
          On the Individual Explorer:

I was testing the guide button [ ? ] under the Visits tab.

The last popup window does not have a "Done" button like the other guides, so when you click "Next", it just leaves you with a highlighted box. You can then click on the page to make it go away.

Originally posted by @tdwils in https://github.com/Biogen-Inc/tidyCDISC/issues/172#issuecomment-1458898333

AARON-CLARK commented 1 year ago

Hi @tdwils, I can't seem to reproduce this issue. Is there some other action you performed in the app to trigger this event? This happened before updating all your pkgs, right? Perhaps we should create a separate branch that everyone could use with all pkgs updated. I'll work on that now.

According to this code chunk, there are three different guides the app will render depending on what datasets are loaded.

(1) With no BDS data loaded: image

(2) With a BDS data loaded, but no ADLB (2) with BDS loaded, including an ADLB. I tested both of these events, and they both end on the same step (with a "Done" button). image

Can you please test again? If it doesn't happen again, perhaps we can mark this one as closed?

tdwils commented 1 year ago

@AARON-CLARK Yes, this was before updating all the packages. I can't reproduce it now, but it was definitely happening. I will close this issue and then watch out for it.