search

Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

Lots of new messaging in the console, perhaps shiny version related #207

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago

Item 4 (latest versions of all packages)

A lot more messages are getting printed to the console when the app is run:

image

Regarding Item 4, I think this is a change coming from shiny version 1.7.2. That version has this change:

Closed #3250:{rlang}/{tidyeval} conditions (i.e., warnings and errors) are no longer filtered from stack traces. (#3602)

It has made the stack trace more verbose. I tested this by using the lock file from the devel branch and updating only shiny to v1.7.2. The additional messages appeared in the console when an error was forced.

In run_dev.R we already have options(shiny.fullstacktrace = FALSE), but it doesn’t seem to affect these messages.

Maybe someone else can look at it so see if there is a way to go back to the less verbose version.

AARON-CLARK commented 1 year ago

@tdwils, I played around in the app for a while and was not able to reproduce. Can you tell us a specific action in the app to generate one of these errors. I'm using the current devel branch, which has the following pkg versions:

image

Jeff-Thompson12 commented 1 year ago

I will also like to add that a lot of these were occurring during the table generation. The newly added tryCatch() with validate() makes them disappear. You can see it in the screen shot with render_gt.

tdwils commented 1 year ago

Yes, they were occurring in the TG. I tried it just now, and the messages are gone.

AARON-CLARK commented 1 year ago

Great! I will close this issue for now. Going forward, if new messaging/warnings/errors pop up, try to get rid of them and if it's persistent, create a new issue for that specific scenario.