Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
107 stars 38 forks source link

Make long facet & legend variables more readable #212

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago

This PR which impacts both the scatterplot and line plot modules and closes #200. See issue for more details!

codecov[bot] commented 1 year ago

Codecov Report

Merging #212 (1eeed0a) into devel (3aecf6c) will increase coverage by 0.22%. The diff coverage is 49.13%.

:exclamation: Current head 1eeed0a differs from pull request most recent head ef3f6b4. Consider uploading reports for the commit ef3f6b4 to get more accurate results

@@            Coverage Diff             @@
##            devel     #212      +/-   ##
==========================================
+ Coverage   19.64%   19.86%   +0.22%     
==========================================
  Files          50       50              
  Lines        4551     4596      +45     
==========================================
+ Hits          894      913      +19     
- Misses       3657     3683      +26     
Impacted Files Coverage Δ
R/mod_indvExpPatEvents.R 0.00% <0.00%> (ø)
R/mod_indvExpPatVisits_fct_plot.R 56.11% <0.00%> (-0.41%) :arrow_down:
R/mod_indvExp_fct_organizeEvent.R 9.09% <0.00%> (-2.91%) :arrow_down:
R/mod_popExp.R 0.00% <0.00%> (ø)
R/mod_popExp_fct_line.R 0.00% <0.00%> (ø)
R/mod_popExp_scatter.R 0.00% <0.00%> (ø)
R/mod_tableGen.R 0.00% <0.00%> (ø)
R/mod_popExp_fct_scatterplot.R 82.11% <95.83%> (+0.46%) :arrow_up:
R/mod_indvExp_fct_buildEvents.R 75.20% <100.00%> (+1.47%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AARON-CLARK commented 1 year ago

Hi @tdwils, this PR is ready for another review. The issue was that the ggplot2 object looked beautiful, but a lot of configurations aren't supported or come out looking quite different when passed through plotly::ggplotly() so I had to make some overall plotly::layout() changes to correct the issue. Let me know how things look on your end!

AARON-CLARK commented 1 year ago

Hi @tdwils, can you please test one more time given my new commits? Before pursuing a plotly margin solution that is a function of other variables, I think / hope the new fix will work for you. 🤞🏼