Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

Better error handling #213

Closed Jeff-Thompson12 closed 1 year ago

Jeff-Thompson12 commented 1 year ago

To me the most sensible way to handle this in general was to create an error handler group of functions. Evidently my brain is stuck on creating S3 methods.

This is still a bit of whack a mole, but I think at least the building blocks for a sensible way to handle these issues generally is in this PR.

If any of you are aware of other situations where we need tryCatch applied. Let me know and I can add it here. I used a word search of stop() but am certainly missing cases where we would want a validate.

codecov[bot] commented 1 year ago

Codecov Report

Merging #213 (27b02f0) into devel (642cca6) will decrease coverage by 0.06%. The diff coverage is 0.00%.

:exclamation: Current head 27b02f0 differs from pull request most recent head e73cf31. Consider uploading reports for the commit e73cf31 to get more accurate results

@@            Coverage Diff             @@
##            devel     #213      +/-   ##
==========================================
- Coverage   19.77%   19.72%   -0.06%     
==========================================
  Files          50       50              
  Lines        4515     4528      +13     
==========================================
  Hits          893      893              
- Misses       3622     3635      +13     
Impacted Files Coverage Δ
R/mod_indvExpPat.R 0.00% <0.00%> (ø)
R/mod_indvExpPatEvents.R 0.00% <0.00%> (ø)
R/mod_indvExp_ui.R 0.00% <0.00%> (ø)
R/mod_popExp_heatCorr.R 0.00% <0.00%> (ø)
R/mod_tableGen.R 0.00% <0.00%> (ø)
R/utils_helpers.R 10.38% <0.00%> (-0.57%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Jeff-Thompson12 commented 1 year ago

Addresses #206

Jeff-Thompson12 commented 1 year ago

Just added a commit to this PR to keep the app from crashing when the data for the individual explorer can't be created.