search

Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
107 stars 38 forks source link

Fix the listeners in script.js #234

Closed Jeff-Thompson12 closed 1 year ago

Jeff-Thompson12 commented 1 year ago

The STAT blocks were not droppable because of nested listeners from Shiny.

@AARON-CLARK There is one intentional change from previous behavior. Previously if no AVISITs were uploaded, the application would still create a dropdown for ANOVA and CHG with NONE being the only option presented. This PR changed that to return no dropdowns which is the behavior for MEAN. I'm unaware of any negative consequences from doing this.

Jeff-Thompson12 commented 1 year ago

I'm also not sure if this is one of my first "fixes" which results in a reduction in the total lines of code.

codecov[bot] commented 1 year ago

Codecov Report

Merging #234 (3cc6658) into devel (dc990c5) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3cc6658 differs from pull request most recent head 78c3a38. Consider uploading reports for the commit 78c3a38 to get more accurate results

@@           Coverage Diff           @@
##            devel     #234   +/-   ##
=======================================
  Coverage   19.38%   19.38%           
=======================================
  Files          54       54           
  Lines        4742     4742           
=======================================
  Hits          919      919           
  Misses       3823     3823

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.