search

Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

Rethink filtering #239

Open AARON-CLARK opened 1 year ago

AARON-CLARK commented 1 year ago

Just trying to acknowledge and document this convo that happened offline:

image

image

AARON-CLARK commented 1 year ago

Hey @Jeff-Thompson12, without looking at those specific functions in a while, I can confirm that the workflow Andrew references is accurate (in general). Why, what did you have in mind?

Jeff-Thompson12 commented 1 year ago

I think I have two main things in mind:

  1. Naming conventions. These naming conventions got adopted into the recipe and blockData workflows. We need to rename. I do not know if there is a convention we should be using so a user not familiar with our package but familiar with table generation would know what they are.
  2. This functionality is only available in the recipe creation. We should allow users to designate filters as applying to the population or to the table.
Jeff-Thompson12 commented 1 year ago

Additionally, even if you don't add any filters but add a dataset on which to filter, the application will filter the table with no indication. Like here I select a standard table and add "ADAE" to the datasets to filter on and the table updates to only subjects with an adverse event.

Snag_ab6303e