BioinformaticsFMRP / TCGAbiolinksGUI

TCGAbiolinksGUI code development for R/Bioconductor submission http://tcgabiolinks.fmrp.usp.br:3838/
http://bioinformaticsfmrp.github.io/TCGAbiolinksGUI
35 stars 14 forks source link

Search Results Summary Lacks Number of Samples #14

Closed DarioS closed 7 years ago

DarioS commented 7 years ago

After doing a molecular data search and applying a filter, it's not clear how many samples meet the rules. Initially, the Summary pie charts are shown, which only display percentages. It's not until expanding the Results panel that the number of samples can be seen in the bottom left corner, below the table. This information should be easier to find.

labrazil commented 7 years ago

Fully agree. Thank you for the suggestion. This should be an easy fix.

tiagochst commented 7 years ago

The number was available if you hover the pie chart like the screenshot below.

captura de tela 2017-05-10 as 00 18 19

But I agree it should be more visible. I'm changing % to values.

captura de tela 2017-05-10 as 13 51 20
labrazil commented 7 years ago

Tiago, I don't agree. Keep the %, and we just need to make a note on that page to inform the user that they can hover over the pie chart to get absolute numbers. Percentages are useful in this regards.

Houtan

-- \hn Ph: +1-310.570.2362 Not sent from my pıoɹpuɐ device.

On Wed, May 10, 2017 at 9:53 AM, Tiago Chedraoui Silva < notifications@github.com> wrote:

The number was available if you hover the pie chart like the screenshot below. [image: captura de tela 2017-05-10 as 00 18 19] https://cloud.githubusercontent.com/assets/145529/25899374/86a94ce2-3587-11e7-8629-6f6fe07764b9.png

But I agree it should be more visible. I'm changing % to values. [image: captura de tela 2017-05-10 as 13 51 20] https://cloud.githubusercontent.com/assets/145529/25899488/faa36cd6-3587-11e7-8106-d71b63170bd3.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BioinformaticsFMRP/TCGAbiolinksGUI/issues/14#issuecomment-300472520, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBCt8HFKgfkr_A_mszWnX7RfLNx9Ua9ks5r4bM8gaJpZM4NTClo .

labrazil commented 7 years ago

Or if possible, a table underneath the pie charts, while still keeping the % in the pie, would suffice this Users suggestion.

Houtan

-- \hn Ph: +1-310.570.2362 Not sent from my pıoɹpuɐ device.

On Wed, May 10, 2017 at 9:55 AM, Houtan Noushmehr houtana@gmail.com wrote:

Tiago, I don't agree. Keep the %, and we just need to make a note on that page to inform the user that they can hover over the pie chart to get absolute numbers. Percentages are useful in this regards.

Houtan

-- \hn Ph: +1-310.570.2362 <(310)%20570-2362> Not sent from my pıoɹpuɐ device.

On Wed, May 10, 2017 at 9:53 AM, Tiago Chedraoui Silva < notifications@github.com> wrote:

The number was available if you hover the pie chart like the screenshot below. [image: captura de tela 2017-05-10 as 00 18 19] https://cloud.githubusercontent.com/assets/145529/25899374/86a94ce2-3587-11e7-8629-6f6fe07764b9.png

But I agree it should be more visible. I'm changing % to values. [image: captura de tela 2017-05-10 as 13 51 20] https://cloud.githubusercontent.com/assets/145529/25899488/faa36cd6-3587-11e7-8106-d71b63170bd3.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BioinformaticsFMRP/TCGAbiolinksGUI/issues/14#issuecomment-300472520, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBCt8HFKgfkr_A_mszWnX7RfLNx9Ua9ks5r4bM8gaJpZM4NTClo .

tiagochst commented 7 years ago

The UI is already quite heavy, I prefere not to add new elements that are not extremely important. I will keep the % and add a bar chart with the number of samples.

labrazil commented 7 years ago

Great point. Thanks Tiago.

Houtan

-- \hn Ph: +1-310.570.2362 Not sent from my pıoɹpuɐ device.

On Wed, May 10, 2017 at 10:07 AM, Tiago Chedraoui Silva < notifications@github.com> wrote:

The UI is already quite heavy, I prefere not to add new elements that are not extremely important. I will keep the % and add a bar chart with the number of samples.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BioinformaticsFMRP/TCGAbiolinksGUI/issues/14#issuecomment-300475974, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBCt5whpYmV-YxDcIk-KE5Y6N_khX_xks5r4bZ6gaJpZM4NTClo .

tiagochst commented 7 years ago

This is the last plot

screen shot 2017-05-11 at 9 41 40 am