Closed drnickisaac closed 4 years ago
@drnickisaac the example in bma fails
data <- data.frame(species = rep(letters, each = 50),
year = rep(1:50, length(letters)),
index = runif(n = 50 * length(letters), min = 0, max = 1),
se = runif(n = 50 * length(letters), min = 0.01, max = .1))
# Run the Bayesian meta-analysis
bma_indicator <- bma(data, model="Smooth")
Error in tolower(model) : object 'model' not found
@drnickisaac There are more issues. Rather than me trying to tackle this can I ask you to run your examples and address all the errors that you get and then put in a new pull request?
# Create some example data in the format required
data <- data.frame(species = rep(letters, each = 50),
year = rep(1:50, length(letters)),
index = runif(n = 50 * length(letters), min = 0, max = 1),
se = runif(n = 50 * length(letters), min = 0.01, max = .1))
# Run the Bayesian meta-analysis
bma_indicator <- bma(data, model="Smooth")
Error in jags.model(file = model.file, data = data, inits = inits, n.chains = n.chains, :
Error parsing model file:
syntax error on line 48 near "{"
@drnickisaac nudge
@drnickisaac nudge
Done!
Hi @drnickisaac are you not getting these errors on your local version?
data <- data.frame(species = rep(letters, each = 50),
year = rep(1:50, length(letters)),
index = runif(n = 50 * length(letters), min = 0, max = 1),
se = runif(n = 50 * length(letters), min = 0.01, max = .1))
# Run the Bayesian meta-analysis
bma_indicator <- bma(data, model="Smooth")
[1] "Warning: No negative index values detected. Are you sure you transformed the data?"
Processing function input.......
Done.
Error in jags.model(file = model.file, data = data, inits = inits, n.chains = n.chains, :
Error parsing model file:
syntax error on line 48 near "{"
Doh!
The problem persists. I suggest looking closely at your syntax once you have parsed your bugs code for smooth
, it looks like there is a bug in there. It might be a good idea to write some tests for this function so that you can catch this before the pull request stage.
@AugustT I think the check failure is only on code coverage, not a bug in my code. Correct?
Correct, all green on Travis
In she goes. Thanks for getting this over the line
Fixed a conflict in the description file (we both updated the authors)