search

BiologicalRecordsCentre / BRCindicators

An R package for creating indicators from trends data
4 stars 11 forks source link

BMA default option doesn't work #58

Closed AugustT closed 4 years ago

AugustT commented 4 years ago

https://github.com/BiologicalRecordsCentre/BRCindicators/blob/abae2ddde01ece2b7e42861f8eca8c7babb347f0/R/bayesian_meta_analysis.R#L60

Quick fix needed @drnickisaac

It appears the default does not work. There is no model option for 'smooth'; compare the model default ('smooth'), to the list of options from L91

I know I sound like a broken record but this is why it is really important to have tests. I don't think I will be excepting any new pull requests on any BRC projects unless they provide tests for the new features they add.

drnickisaac commented 4 years ago

Done on my version - now with pull request.

AugustT commented 4 years ago

Best not to close it in case there are issues with the pull request. Instead you can now link this issue to your pull request on the right hand side of this page, when the pull request is merged this issue automatically closes. I have just done that for this issue.