The bma method will be underpinned by the Freeman et al paper, so it would be worth harmonizing the code so that variable names match up. The following need to be renamed in both bma_model_Smooth() and where parameters are monitored, from line 190-203. I think it's just the following four parameters that need changing:
spindex -> S
logLambda -> G
spgrowth -> R
FY -> F
If we're making these changes, it would make sense to give other variables more intuitive names:
estimate -> index (or index.obs)
Note that the parameters to model section is currently written to be compatible with a large number of alternative forms of bma, all of which have now been deprecated. So this section could be substantially tidied. If so, we could also remove the model option, which only exists for backward compatibility.
The
bmamethod will be underpinned by the Freeman et al paper, so it would be worth harmonizing the code so that variable names match up. The following need to be renamed in bothbma_model_Smooth()and where parameters are monitored, from line 190-203. I think it's just the following four parameters that need changing:If we're making these changes, it would make sense to give other variables more intuitive names:
Note that the parameters to model section is currently written to be compatible with a large number of alternative forms of bma, all of which have now been deprecated. So this section could be substantially tidied. If so, we could also remove the
modeloption, which only exists for backward compatibility.