BiologicalRecordsCentre / BSBI-Card-and-PlantPortal-DEPRECATED-

A portal to promote plant recording and analysis of plant data
0 stars 0 forks source link

Code Update Requests #47

Closed andrewvanbreda closed 5 months ago

andrewvanbreda commented 7 years ago

Nested in #46

Biren: I have attached the zipped version of the file that should be used as the config file for the indicia_svc_plant_portal_import folder on the dev warehouse. Could you move it across whenever you get a chance

plant_portal_import.php.zip

andrewvanbreda commented 7 years ago

Yes @JimBacon that would make sense, I will take a look at trying to include that.

Actually it might be a thought if sometime in the future we make it visually clearer whether we are running live, dev on the test warehouse and branches that are being run. At the moment even my own machine warehouse looks like live unless I check the URL, it wouldn't be too bad apart from I want to run scheduled tasks on my own machine, def wouldn't want to get that mixed up with live I might use your suggestion of changing template.php to make this clearer on my own machine at least.

johnvanbreda commented 7 years ago

There is a config setting called warehouse_title in the indicia.php config file that at least partially solves this. We may need to make it clearer.

BirenRathod commented 7 years ago

At least on dev warehouse, 'dev' has already placed that.

andrewvanbreda commented 7 years ago

OK, thanks, I will do that on my own machine. It is only the scheduled tasks running on my own box which become a problem where trouble could really occur if a mistake is made, any attribute editing it is always obvious.

andrewvanbreda commented 7 years ago

@birenrathod sorry for the delay, it went a bit chaotic after merging wiped out all my changes in the feature branch because I had previously had to undo some changes in Develop and these undos got copied too :( Anyway, I think it is fixed now, so try and give it a go at update the dev warehouse whenever you are ready. All being well no-one will notice a difference apart from me

andrewvanbreda commented 7 years ago

oh, the feature branch to use in feature-plant-portal-importer-may-build

BirenRathod commented 7 years ago

Dev warehouse has been switched on to feature branch (feature-plant-portal-importer-may-build).

andrewvanbreda commented 7 years ago

Brilliant, thanks will take a look, hopefully no-one else will notice a difference apart from I have used @jimbacon suggestion of labelling the footer on the home-page

andrewvanbreda commented 7 years ago

Hi @BirenRathod, Most of the deployment of the dev plant portal importer has worked with one exception. The config file on the warehouse has been overwritten. I thought this was a problem, however I release it might be a good thing as it would have been wrong. Find attached, this needs to go into the config folder in the warehouse indicia_svc_plant_port [Uploading plant_portal_import.txt…]() al_import module (the extensions also needs renaming to .php)

andrewvanbreda commented 7 years ago

plant_portal_import.txt