search

BiologicalRecordsCentre / BSBI-Card-and-PlantPortal-DEPRECATED-

A portal to promote plant recording and analysis of plant data
0 stars 0 forks source link

Hide vague boundary centroids from user in error reporting #60

Closed sacrevert closed 5 months ago

sacrevert commented 7 years ago

From #48 : File 3's row 3 is missing a spatial reference but also a vice county and country to fill it in with. The user is warned this must be corrected before an upload can continue. Not also on the warnings screen that row 2 has its spatial reference generated by the vice county and the spatial reference system is present even though it was missing in the original file Test File for Oli 3.txt

OLP response: This is fine, although I'm not overly keen on the lat/long centroid(?) appearing in the SPATIAL_REF column. I presume that this is the spatial ref auto-generated by the vice-county? My issue with this is that it seems to me like it may result in the spurious association of the occurrence with a highly precise location (the VC centroid), rather than a proper attribution of the occurrence to a vague area (i.e. anywhere within the VC polygon). I realise this might be a feature of the system, but can you think of downstream issues that might arise through including a precise centroid in the SPATIAL_REF column? Perhaps it is standard and there is nothing to worry about.

Also, the error reporting here is better laid out than for Test Files 1 and 2. Is this something that will be unified? The table layout looks really nice.

AVB response: I will address the unification of error messages first. The answer is they can’t easily be unified, as one screen are warnings specific to Plant Portal, the other screen is now part of the standard importer and the warnings are generated by talking to the warehouse first. This extra warnings screen basically avoids the problem of the warehouse reporting errors but importing other rows OK. Now it won’t import unless there are no errors are all for Plant Portal So the warning types are different and the screens are placed in completely different places in the code, having said that there is no reason whatsoever why you can’t make suggestions on making any of the warnings screens look better.

In response to the spatial references, the sample has to have a spatial reference. It is only a Lat/Long as that is the default I chose for the Vice Counties/Countries. We could make the spatial reference vaguer if you wanted, like a low precision British National Grid reference? The spatial reference doesn’t need to even be the same as what is in the warehouse, I use a separate lookup list (much faster) stored in the page configuration so the spatial references could all be on the moon if you liked. Or we could have the spatial reference in the background and not show the user.

This item is not urgent, and awaits future funding.

Nested in #46