Admin/configuration areas of site fall over

[andrewvanbreda]

Hi @BirenRathod (and @sacrevert FYI)

I am noticing recently the NPMS site is giving errors in its admin areas, to the point where I can no longer configure the site. The affected paages are completely falling over, not just warnings.

Would you be able to look at this please?

e.g. going to Reports menu->Status Report results in this in the Drupal logs ArgumentCountError: Too few arguments to function Drupal\embed\EmbedType\EmbedTypeBase::__construct(), 3 passed in /code/web/modules/contrib/entity_embed/src/Plugin/EmbedType/Entity.php on line 56 and exactly 4 expected in Drupal\embed\EmbedType\EmbedTypeBase->__construct() (line 29 of /code/web/modules/contrib/embed/src/EmbedType/EmbedTypeBase.php).

Going to an Indicia page, and clicking Edit results in many messages (about 8)...here are 2 examples.

Entity view display 'node.webform_report.default': Component 'comment_node_webform_report' was disabled because its settings depend on removed dependencies.

Entity view display 'node.online_training.default': Component 'comment_node_online_training' was disabled because its settings depend on removed dependencies.

[sacrevert]

@andrewvanbreda this sounds quite serious, but @BirenRathod is on leave. Not sure who else might be able to look at this? @JimBacon @burkmarr @DavidRoy

[andrewvanbreda]

@sacrevert Well I assume the public areas are OK, but it does mean I can't save configuration changes. For example issue 334 is a report change that needs a new parameter, I cannot add that parameter to the configuration at the moment. Note, I tried clearing Drupal caches and also the caches in Pantheon which didn't work. If worst comes to worst, if no-one is available I could perhaps create a multidev clone in Pantheon and fiddle with that. The only problem with that is this isn't my usual area ,and even if I did find a solution I wouldn't be sure necessarily that it was a good solution an system administrator might approve of.

[andrewvanbreda]

Hi @sacrevert I have taken a quick look at Google. I THINK the problems are two-fold.

1. A bug in the Embed module, this has an update available.
2. The Admin Toolbar module being incompatible with the latest Drupal version.

I suggest I don't fiddle with the site (as I don't know if the update pages would be damaged for example, nor do I know anything about recovery amongst other reasons etc).

Instead

1. This means the rollout of fixes to the Site Details page link will be delayed. The improvement I added last week is already present though (where the Grid Ref is updated as popup is opened).
2. Yesterday's requested change to Square Details Per Year report will break that page once it is pulled onto the Warehouse. So when that change goes live (and the page breaks) I will send NPMSSupport a link to the new version of the report which can work on one of my Pantheon Multidev sites which does not have the issue.

[burkmarr]

Looking at Pantheon, it seems that the problem started with this recent update to Drupal:

That was applied to dev and then propagated to test and live. But where it hasn't reached - e.g. the burkmar1 multidev site - the problem with the admin pages doesn't occur. I agree with Andy that if problem lies with the Embed and Admin Toolbar modules and since user-facing pages are unaffected, it would be wise to wise to wait for @BirenRathod to take a look at this.

[BirenRathod]

@andrewvanbreda & @sacrevert I have rolled out another Drupal update that should resolve the issue you experienced before.

[andrewvanbreda]

Thanks @BirenRathod, that seems to be working fine now on live.