BiologicalRecordsCentre / SPRING

Repository for tracking issues for the SPRING (EU Pollinator Monitoring) project
GNU General Public License v3.0
0 stars 0 forks source link

SPRING: walk-data-entry layout #52

Closed DavidRoy closed 2 years ago

DavidRoy commented 2 years ago

Improve layout of walk-data-entry form. @BirenRathod can you take on this design improvement? https://test-eu-pollinator.pantheonsite.io/walk-data-entry?

The current page is like this: spring walk-entry

Ideally it would match the compact form of the ukbms: ukbms walk-entry

Otherwise, the ebms layout would be ok. ebms walk entry 2

The most important thing is the order of the data entry fields: start time, end time, %Sun, Temp, Wind direction, Wind speed, Notes

DavidRoy commented 2 years ago

@BirenRathod can you also fix the theme for the buttons at the bottom of the page.

It looks like this on the first page eupoms - button1

And this on the second eupoms - button2

BirenRathod commented 2 years ago

@andrewvanbreda I have resolved the css style problem on this _> https://test-eu-pollinator.pantheonsite.io/walk-data-entry. Can you re-order those attributes which David has suggested here? It will be easier to do for you than me.

BirenRathod commented 2 years ago

@BirenRathod can you also fix the theme for the buttons at the bottom of the page.

It looks like this on the first page eupoms - button1

And this on the second eupoms - button2

@DavidRoy Margin and size of buttons have been implemented now.

DavidRoy commented 2 years ago

Thanks Biren - much better.
@andrewvanbreda let me know when you've sorted out the attribute order

andrewvanbreda commented 2 years ago

@DavidRoy @BirenRathod Ok, I will have a look again how this is working in the EBMS code.

andrewvanbreda commented 2 years ago

@DavidRoy @BirenRathod Have used the survey attribute layout editor in the Warehouse to match this up with EBMS. The attributes are drawn left to right, on a row to row basis after the Date. However this does means that the Recorder Name attribute is appearing to the right of the date. This is consistent with EBMS (apart from we are using two columns), but it is not consistent with that UKBMS screenshot. Let me know which way around they should be, if it they are supposed to be the other way around, I will have to write some jQuery to switch them I think.

andrewvanbreda commented 2 years ago

Hi @BirenRathod Unfortunately the layout seems to have broken again, particularly adding new walks. I think it became broken again as some things changes on the page. Could you let me know where you added the stylesheet changes to fix the previous layout (or if you can fix this easily that would be even better).

See screenshot.

Cheers

Screen Shot 2022-07-15 at 09 41 33

BirenRathod commented 2 years ago

@andrewvanbreda I have amended style and js file, so it should display much better way. you can find those files are node.29.js & node.29.css in files/indicia folder. There are still some chnages needed but I will do some other time but atleast it is in presentable form. Also, fields in "Transect walk type" display should be inline with each other. not sure are you thinking same way or not?

andrewvanbreda commented 2 years ago

Hi@BirenRathod Thanks for doing that, looks much better than it did. I will make some further adjustments later, so the right-side is shift down one so the time comes out on one line. Ah yes ok, thanks for letting be know they are in node specific files, that is good place for them. As those aren't under git control I always commit a copy to support files, so I will commit your changes there. Yes I see what you mean about those labels, I didn't notice that before. I will fix them later. Leave this issue open for now.

andrewvanbreda commented 2 years ago

@DavidRoy Have many further adjustments to the way the page looks. Awaiting any further comments. Note the page does have several modes, so worth looking at both new walks and editing existing

DavidRoy commented 2 years ago

Thanks for improvements