FITcount regional co-ordinator role

DavidRoy commented 3 years ago

linked to #6, we'll need:

a Drupal regional co-ordinator role to enable download by country (e.g. using Country 2016 layer)
an interface for assigning users to a country

@andrewvanbreda if this is best handled by Jim, let me know

andrewvanbreda commented 3 years ago

@DavidRoy I will do this, as there may be similarities to NPMS where users are assigned to squares and events (both of which are locations). Although in this case the difference would be that it is just one country.

andrewvanbreda commented 3 years ago

Note that the user country assignment to use now has its own issue #13 as I think it warrants that.

Only requirement needs completion for this issue (although there will be some overlap) "a Drupal regional co-ordinator role to enable download by country (e.g. using Country 2016 layer)"

andrewvanbreda commented 3 years ago

Note that we have had a meeting and it is only the "regional co-ordinator" role that needs a country assigned to them, so ignore the above comment.

Situation summary

Regional co-ordinator role needed for both FIT Count and EU PoMS site
Country selection drop-down available for this role only on the account page for the site (the selection is not linked between the two sites)
Download is based on a spatial query, it is not related to the country selected on the sample
The data that can be downloaded is currently the same as what is available for individual users on UK PoMS

This requirement is currently at the highest priority level.

andrewvanbreda commented 3 years ago

@DavidRoy Should the Regional Co-ordinators be able to see locations with full precision?, as on FIT Count data entry forms the data is blurred. I assumed yes they should, but need to check with you.

andrewvanbreda commented 3 years ago

@DavidRoy A couple of other questions

What surveys do we include? The My Records on UK PoMS allows the following 3 Public FIT Count 1km FIT Count FIT Count App This is also listed in a column on the report.
Which countries are we going to use? Noting again the country is displayed as a column on the report, but also needs to go on the account page country selection field as well

Again initially I am doing this as a modified version of UKPoMS report with a move to ElasticSearch when I am confident it can support all the equivalent functionality and I know how to implement them.

andrewvanbreda commented 3 years ago

@BirenRathod Hi Biren,

Whenever you get chance, could you pull these two reports onto the live Warehouse please. reports/projects/PoMS/regional_coodinator_download_grid.xml reports/projects/PoMS/regional_coodinator_download_map.xml Thanks

BirenRathod commented 3 years ago

@andrewvanbreda both pulled down on to live.

andrewvanbreda commented 3 years ago

@BirenRathod Thanks Biren

DavidRoy commented 2 years ago

@andrewvanbreda in answer:

@DavidRoy Should the Regional Co-ordinators be able to see locations with full precision?, as on FIT Count data entry forms the data is blurred. I assumed yes they should, but need to check with you. = yes

What surveys do we include? The My Records on UK PoMS allows the following 3 Public FIT Count 1km FIT Count FIT Count App This is also listed in a column on the report. = all these surveys to includ

Which countries are we going to use? Noting again the country is displayed as a column on the report, but also needs to go on the account page country selection field as well = all in the Countries 2016 list

andrewvanbreda commented 2 years ago

@DavidRoy Sorry slow to reply to this as was away at beginning of week. This is all ok, apart from perhaps the countries list is tricky as it was going to be a drop-down, but I see there are 258 entries. Will see if I can test this on my own box, see what it is like and come up with alternative if needed.

andrewvanbreda commented 2 years ago

HI @JimBacon Would you be able to get this data from the live warehouse please

select id || '|' || name from indicia.locations where location_type_id = 16516 and deleted=false order by name asc;

Email me if you don't think it should be posted onto public Github (or let me know if you can't, and I will ask John as Biren is away)

Cheers

JimBacon commented 2 years ago

andrewvanbreda commented 2 years ago

@JimBacon Thanks Jim BTW could you just have a peek in your junk email, as sent an email yesterday I am not sure you saw. Cheers.

andrewvanbreda commented 2 years ago

Hi @DavidRoy,

I have done a preliminary version of this on FIT Count (not in menu yet until you give your opinion)

It is here

https://fitcount.ceh.ac.uk/regional-coordinator-download

Download is same as UK PoMS My Records.

Only accessible to Regional Coordinators and admins.

Country is set via a drop-down on My Account pages. (This is a long drop-down, user can press key on their keyboard when drop-down selected to jump to countries beginning with that letter. Seems ok to me).

Country drop-down only selectable by administrator at moment, and only viewable by Regional Coordinator (I assume you don't want them setting it themselves. If you want to try it yourself, you can set a Country on your own account.

Once you are happy with this arrangement I will also put on EU PoMS

A couple of thoughts

Currently if the country isn't selected, it returns data from all countries. I will change this to default to none before live. I only just noticed this.
Another thought to consider. The system currently has a very literal view of the countries. So if UK is selected, it shows UK. So the assumption is that the "regions" for the regional coordinator match up with this. So for instance, the Channel Island data is separate to UK. I raise this as UK PoMS does include Channel Islands.

DavidRoy commented 2 years ago

This works well via admin login. I also tried for user (https://fitcount.ceh.ac.uk/user/67) by setting role as 'Regional co-ordinator' and selecting country = Sweden. But when masquerading as that use and going to https://fitcount.ceh.ac.uk/regional-coordinator-download I get an access denied message. Am I misunderstanding something @andrewvanbreda ?

andrewvanbreda commented 2 years ago

Hi @DavidRoy Thanks for letting me know about this issue. I have fixed this. There were 2 problems causing this in the permissions, I have corrected them.

Again, let me know if you have any further thoughts, and I will move this into final testing, then the live menu.

DavidRoy commented 2 years ago

Thanks @andrewvanbreda That works. Can you add a new menu item "Regional results" pointing to: https://fitcount.ceh.ac.uk/regional-coordinator-download. Only visible to users with role = Regional co-ordinator

andrewvanbreda commented 2 years ago

@DavidRoy Will do, I need to make one change to report before going live (no Country selection currently returns all data, should be none) I will let you know when live.

andrewvanbreda commented 2 years ago

@JimBacon Hi Jim,

In the absence of Biren would you be able to pull these two reports from indicia-reports onto live please? These are not used by any live page yet so this is safe. Just a slight alteration to stop all data returning if no country has been selected for regional coordinator.

/projects/PoMS/regional_coodinator_download_grid /projects/PoMS/regional_coodinator_download_map

Cheers

andrewvanbreda commented 2 years ago

Thanks Jim

@DavidRoy This is now live. I have checked it. Check you are happy and close if you are.

The things I checked include

Non-regional coordinator cannot access page via menu or direct URL entry
Regional coordinator can download data for their country
Regional coordinator without a country assigned yet can't see any data yet.

DavidRoy commented 2 years ago

Thanks for implementing this

BiologicalRecordsCentre / SPRING

FITcount regional co-ordinator role #8