BiologicalRecordsCentre / UKBMS-online

Issue tracking for UKBMS online recording site
2 stars 0 forks source link

Changes to Create New Account form #176

Closed MeganLowe closed 3 years ago

MeganLowe commented 3 years ago

Hello, I have a few suggested changes for the Create New Account (registration) form on the new ukbms as follows:

For info here's the link to the current registration form on ukbms: https://www.ukbms.org/mydata/user/register

We may need to review the automated email reply too - how can I find/amend this?

Thanks, Megan

Gary-van-Breda commented 3 years ago

@DavidRoy : Should this be done by @BirenRathod or me?

DavidRoy commented 3 years ago

@Gary-van-Breda can you pick this up and involve @BirenRathod as needed. Thanks

BirenRathod commented 3 years ago

Yes, that's right. @Gary-van-Breda let me know if you need anything.

Gary-van-Breda commented 3 years ago
Gary-van-Breda commented 3 years ago

@BirenRathod : there seems to be 2 CSS definitions for .form-required:after: one in the UKBMS theme overrides.min.css, and one in https://cdn.jsdelivr.net/npm/@unicorn-fail/drupal-bootstrap-styles@0.0.2/dist/3.4.0/8.x-3.x/drupal-bootstrap.css. These each add one of the asterisks, but the overrides does not switch off the bootstrap derived one.
Can you sort this out?

Gary-van-Breda commented 3 years ago

@DavidRoy : did we not take a conscious decision to remove both the under 16 and "About your surveys" fields? I can't find an evidence trail.

Gary-van-Breda commented 3 years ago

@MeganLowe : the email templates can be found at the bottom of https://test-ukbms8.pantheonsite.io/admin/config/people/accounts
I've given permissions top access this to the site editor role, so you should now be able to see it. Please be careful about the other fields on this page.

BirenRathod commented 3 years ago

@BirenRathod : there seems to be 2 CSS definitions for .form-required:after: one in the UKBMS theme overrides.min.css, and one in https://cdn.jsdelivr.net/npm/@unicorn-fail/drupal-bootstrap-styles@0.0.2/dist/3.4.0/8.x-3.x/drupal-bootstrap.css. These each add one of the asterisks, but the overrides does not switch off the bootstrap derived one. Can you sort this out?

@Gary-van-Breda Which page is this on? I know I could find in the css file but I need to see on the page too.

BirenRathod commented 3 years ago

@Gary-van-Breda Don't worry, I found it now.

BirenRathod commented 3 years ago

@Gary-van-Breda It has resolved now. that overrides.min.css file is the old version of bootstrap subtheme code. It should not be there in theory. I haven't removed yet, I'm not sure will that cause any thing else but I found other way round to solve this problem by tweaking theme settings to custom instead of using jsdeliver.

Let me know if you see any other problem due to this, otherwise we stick with this.

Gary-van-Breda commented 3 years ago

@MeganLowe : can you review this and check if it has been completed to your satisfaction?

MeganLowe commented 3 years ago

Looks good, thanks @Gary-van-Breda