BiologicalRecordsCentre / UKBMS-online

Issue tracking for UKBMS online recording site
2 stars 0 forks source link

Changes to UKBMS location grid refs not reflected in iRecord outputs #188

Open IanMiddlebrook opened 3 years ago

IanMiddlebrook commented 3 years ago

Hi,

Documenting a recent email exchange concerning a problem with grid references in iRecord.

A UKBMS section (Grangelands, section 7) was found to have the wrong grid reference (a historical error). The section was adjusted on the route map website, so that the grid ref was then correctly calculated. This change appeared immediately in any fresh data download from the UKBMS website. However, on iRecord, the records still appear to the county verifier with the previous, erroneous, grid reference.

@DavidRoy has said: "I suspect that the ‘raw’ data is correct in the database but the summary tables (ElasticSearch) we use for the website reports (e.g. verification page) has not updated after the location was updated."

Thanks, Ian

Gary-van-Breda commented 2 years ago

We have to be a bit careful here. When the grid reference was changed on the location, it was not automatically changed on all the walk section samples associated with it (the philosophy behind this may be that if there is a genuine change to the section route and hence the section gridref, you don't want to change the old correct sample gridref - but that may not be how we manage sites, so may be irrelevant). there is no code to do this automatic change. The downloads are taking the grid ref from the location, whilst I suspect the iRecord data is coming from the samples themselves, which have the old grid reference.

As an aside, there also seem to be a whole set of data upload walks which have no grid reference on the sample record.

@DavidRoy @IanMiddlebrook : two questions:

IanMiddlebrook commented 2 years ago

Hi @Gary-van-Breda @DavidRoy

Thanks, Ian

Gary-van-Breda commented 2 years ago

@DavidRoy : are you OK with me adding this functionality? (whenever the grid reference on a section is changed, all the subsamples that reference it will be updated to use the same grid reference).