BiologicalRecordsCentre / UKBMS-online

Issue tracking for UKBMS online recording site
2 stars 0 forks source link

Data Entry Problems on different Browsers #209

Closed IanMiddlebrook closed 3 years ago

IanMiddlebrook commented 3 years ago

Hi @DavidRoy @Gary-van-Breda

I'm starting to hear of a few problems with data entry - possibly browser related?

One recorder, using Microsoft Explorer, got through the first Walk Data Entry page, but was unable to bring up any sort of species list on the second page. I managed to help him progress using Google Chrome instead.

Another recorder is unable to proceed beyond the first Walk Data Entry page. He is using Microsoft Edge: I couldn't get beyond the screen requiring start/end times, etc. I input the start time using 24 hour format, as requested. It immediately turned it into 12 hour format. When I eventually clicked on next, I got the red message shown in the screen shot asking for %S. I've no idea what this means. Can you help? Also, do the two hyphens after the hour and minute fields mean anything? 2021-03-31 2021-03-31 (1) Screenshots attached.

I'm having no trouble with Microsoft Edge - Version 89.0.774.63 (Official build) (64-bit). But I wonder if it's to do with time settings on his computer?

Any help appreciated.

Thanks, Ian

IanMiddlebrook commented 3 years ago

Hi, additional comment from the second user above: Actually, I was using Mozilla Firefox. I have Edge available [89.0.774.63 (Official build) (64-bit)]. When I log in using Edge, I still get the same 6 date format hyphens and it changes my input to 12 hour format, but it does at least accept my entry and let me proceed to inputting my sightings.

IanMiddlebrook commented 3 years ago

Hi, Just to confirm the first point - I've had feedback from another user of Microsoft Explorer who cannot get a species list up on data entry.

IanMiddlebrook commented 3 years ago

Hi, Another report of the second problem: I use Mozilla Firefox as the default on my laptop. I then tried Microsoft Edge. Same problem. Moved to the wife's desktop, which uses Bing - problem solved!

Obviously not clear whether it was the change of browser or change of computer that solved the problem.

DavidRoy commented 3 years ago

Bing is a search engine, not a browser. @IanMiddlebrook can you test on FireFox please

IanMiddlebrook commented 3 years ago

Hi @DavidRoy It works OK on Firefox for me. I suspect it's an issue with time settings on each computer? But that's just a layman's guess! Thanks, Ian

DavidRoy commented 3 years ago

shall we close this issue as it could eat up a lot of time resolving?

IanMiddlebrook commented 3 years ago

Surely it needs to be resolved if several recorders are not able to enter their data!

DavidRoy commented 3 years ago

Sorry, yes. I'd forgotten this was not an isolated issue.

Gary-van-Breda commented 3 years ago

Yes, this is a computer settings problem.
As discussed in " https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time ", the input field takes its 12/24 hour setting from the (local) operating system: as can be seen in the bottom right hand corner of the screenshots above, the time is being displayed in 12 hour mode on the computer.
IMPORTANT: even though the time is being displayed in 12 hour mode in the input control, it is still stored as 24 hour.

There are 2 ways around this:

@IanMiddlebrook @DavidRoy : what is your preference?

IanMiddlebrook commented 3 years ago

Thanks @Gary-van-Breda @DavidRoy Surprising, as this wasn't a problem on the old website. I don't use any other website that insists I change my local settings in order for them to work, and the second solution sounds a bit convoluted. Is there no way this field could operate without taking its setting from the operating system?

I've added a note to the top of the page for now.

Thanks, Ian

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda

There is also the issue of no species list appearing in Microsoft Explorer. Should I separate this one?

Thanks, Ian

Gary-van-Breda commented 3 years ago

@IanMiddlebrook Can you confirm the operating system and IE version of the person who is having problems?

With the upgrade to Drupal 8 from 7, we have got a more up to date version of the IForm Library within which the ukbms forms are built. This has seen development to bring it in line with HTML5: so the control for entering the time is no longer a text field with an enforced format (which was the case in the old site), but now uses the new HTML5 time field type - this should provide the same time interface across all websites which use it, making it more familiar to the user. It does have this downside - there does not seem to be any way to override the operating system setting.

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda - not sure which of the problems you're asking about, but it's not just one person, it's several (for both problems).

For the problem with species lists not appearing at Data Entry, the first few people who had the problem were all using Internet Explorer. I've just opened this up and had a go. Sure enough, it did not give me any species list to enter data. This is my version: image I also noticed that the search box for adding new species to your list didn't work, and was much smaller than However, I should also note, the most recent person to complain of this problem said they were using Chrome (now resolved).

For the problem with the start/finish time fields, these users tried a range of browsers and had problems with all of them. However, since I put up the explanatory note on the data entry page about entering AM or PM, I've not had any more problems reported. I will just add here, that when I just tried Internet Explorer, the start/finish time fields were not populated with the colon - I had to type the colon myself. not a problem, but it clearly behaves differently.

Hope that helps.

Thanks, Ian

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda,

Sorry, have just realised another recorder with this problem of no species list is using a Mac: I signed in (or my mac did) and entered the walk details OK, however, when it came to entering data I could not further than the position shown on the screen shot - no way to display the species and then enter data. My operating system is OS X 10.9.5 and I’m using Safari as my browser.

IanMiddlebrook commented 3 years ago

Just quickly - the Chrome user who reported no species list has now been successful, so it's down to Explorer and Safari.

IanMiddlebrook commented 3 years ago

The latest user to have no species list - Microsoft Explorer ( Windows 8.1) - has resolved using Chrome.

Gary-van-Breda commented 3 years ago

@IanMiddlebrook @DavidRoy Fix applied to live to remove what is know as an "arrow function call": this is a modern Javascript innovation that IE can't handle, and possibly Safari as well.
Whilst I have checked IE on my machine, and that is working OK, I have not been able to check Safari. Could you arrange for the user to try again?

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda

Has this fix definitely gone live? I've tried again in IE, cleared cookies etc, but still can't bring up a species list. I've asked the Safari user to have another go.

Thanks, Ian

Gary-van-Breda commented 3 years ago

@IanMiddlebrook Yes - I've just had a look at it, and it is definitely there: can you try again?

IanMiddlebrook commented 3 years ago

Thanks @Gary-van-Breda - yes, it's worked this time.

Many thanks, Ian

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda The Safari user has now got back to me and has been successful.

Many thanks, Ian

Gary-van-Breda commented 3 years ago

@IanMiddlebrook : is there anything outstanding on this issue now?

IanMiddlebrook commented 3 years ago

@Gary-van-Breda Only if a neat solution can be found for the 12 hour display problem, but that's not critical.

Thanks, Ian

Gary-van-Breda commented 3 years ago

I can't see one: @johnvanbreda - do you have any thoughts?

johnvanbreda commented 3 years ago

@Gary-van-Breda I wasn't aware that the time_input control has changed due to the adoption of HTML5 for the date_picker. How exactly is the time input control being added to the page, and which prebuilt form is this for?

Gary-van-Breda commented 3 years ago

Sorry, my mistake - this is specific to this form: @johnvanbreda please ignore. The time fields are specifically changed in the form: I'll investigate further.

Gary-van-Breda commented 3 years ago

The code to switch the time input types to HTML5 compliant (type="time") has been in place since June 2016 (this was done as part of the requirements to not have to type the colon). This functionality has not changed since the previous D7 site, and is also the case for EBMS/ABLE. Are we OK with it?

IanMiddlebrook commented 3 years ago

Hi @Gary-van-Breda I've not had any more comments from recorders on this issue since I added a note to the data entry form 13 days ago. So I'm happy to close it now.

Thanks, Ian

Gary-van-Breda commented 3 years ago

Note to @johnvanbreda : the timeentry code (time_input control) suffers from the $.browser issue. We re not using that here.