BiologicalRecordsCentre / bsbi-atlas-drupal8

0 stars 0 forks source link

Add selected country to attribution text of trend plot downloads #17

Closed burkmarr closed 12 months ago

burkmarr commented 1 year ago

From @sacrevert: "is it possible to add the selected country to the trend plot downloads, perhaps in the attribution text?"

burkmarr commented 1 year ago

@sacrevert - this is now addressed on https://dev-brc-plantatlas9.pantheonsite.io/.

sacrevert commented 1 year ago

Sorry, don't know why I thought it was already doing this, but I see it isn't: can we add the short-term/long-term info to the plots too please? @burkmarr

sacrevert commented 1 year ago

I just remembered that of course figs 1-3 already show dates, so it wasn't needed. I forgot that fig 4 lacks that context however. Perhaps you can reopen this, or create a new issue, as you like. No rush at all for this of course

burkmarr commented 12 months ago

I want to fix https://github.com/BiologicalRecordsCentre/bsbi-atlas-drupal8/issues/18, so I'll tackle this at the same time.

burkmarr commented 12 months ago

@sacrevert - just to avoid any toing and froing, can you specify the text to add to figure four. (I don't know if the words 'short-term' and 'long-term' are enough or if you want to specify dates.)

burkmarr commented 12 months ago

@sacrevert - another question. I've just realised that figure 3 doesn't show dates either, so presumably treat this the same way is figure 4?

sacrevert commented 12 months ago

Yes, I realised that too. I think just apply the text to all trend figures to simplify solution. "short-term"/"long-term", however phrased, is fine. For example, "Data is for long-term trend, Scotland." etc

burkmarr commented 12 months ago

Fixed on live.