BiologicalRecordsCentre / bsbi-atlas-drupal8

1 stars 0 forks source link

Authorities italicised in atlas page citations #4

Closed sacrevert closed 1 year ago

sacrevert commented 1 year ago

Very minor, but, if possibe, it would be nice to unitalicise species' authorities in the page citation texts, and in the citation reference manager tagging

burkmarr commented 1 year ago

@sacrevert - I've updated the code for formatting the page citation text, the citation on a downloaded map and the metadata tags for the reference managers. In the limited testing of the latter that's available to me, the citation managers seem to ignore any html formatting within the metadata tags. I've implemented on the test site but not yet pushed to live.

https://test-brc-plantatlas9.pantheonsite.io/

Take a look and if you are happy with it I will push to live.

sacrevert commented 1 year ago

Thanks Rich. It's better in terms of presentation on the website, and in terms of the "copy HTML" tagging, but in Zotero the "span class" markup appears in the bibliography in Word. I know you said that this is difficult given that there is no single refman standard to rule them all, so I am tempted to ignore this, and let people manually edit their reference lists after auto-generation. So, happy for it to go live, unless you want to spend extra time fiddling!

burkmarr commented 1 year ago

I might be able to fix that fairly simply Oli. I'll take a look before pushing to live.

burkmarr commented 1 year ago

That should be fixed now I think @sacrevert. If you'd like to take another look at test and if all okay, I will push to live.

burkmarr commented 1 year ago

Hold on - I just spotted a problem. The html tags are going into the pages title tag and appearing on the Chrome tab! I'll need to sort that.

sacrevert commented 1 year ago

This is what it looks like in Word with Zotero now, all italics. Again, not a massive problem (people can edit), so, up to you whether you persevere or not! image

Ignore this, not from test site!

burkmarr commented 1 year ago

Does it look okay from test @sacrevert?

sacrevert commented 1 year ago

Looks great, only issue I can see is that markup is appearing on page title in browser tab: image

burkmarr commented 1 year ago

Yes (see https://github.com/BiologicalRecordsCentre/bsbi-atlas-drupal8/issues/4#issuecomment-1480988898). I've just pushed a change to test that fixes that. Can you check that zotero has retained it's formatting? (There's a chance that it may be getting it from the title tag that the citation_title meta tag).

sacrevert commented 1 year ago

Looks fine to me (see below), and it presented correctly in Word too.

image

burkmarr commented 1 year ago

Okay it's live now.