BiologicalRecordsCentre / eBMS

0 stars 0 forks source link

User access to "Sites" #33

Closed xaviermestdagh closed 5 years ago

xaviermestdagh commented 7 years ago

A new user (Lionel L'Hoste) is not able to see sub elements like "My sites" or "My walks" from the menu "My data" (My data/Sites, My data/Walks...), so that he cannot create new sites nor encode walks...

DavidRoy commented 7 years ago

Lionel is now set with the right permissions. Please let me know if not

xaviermestdagh commented 7 years ago

Thanks, I will ask him. Is a confirmation of access required from you each time a new user is created? Alain Dohet also created an account today, with the aim to encode in Luxembourg.

DavidRoy commented 7 years ago

I've activated Alain's account. When the site is fully up-and-running we'll remove the confirmation step - would you prefer that?

xaviermestdagh commented 7 years ago

Thanks. Perhaps yes, but as you said once it is fully up-and-running.

xaviermestdagh commented 7 years ago

@DavidRoy I just asked to a first set of observers (list here below) to encode one of their site, I will then look how data are encoded, if it's ok. So could you activate also their account once they are registred? Thanks have a nice day "Michelle Clemens" m.clemens@naturemwelt.lu, "Mireille Molitor" m.molitor@naturemwelt.lu, Jenny Renaut/LIST, hellersk@pt.lu, "Gérard Schmidt" gla.schmidt@gmail.com,

DavidRoy commented 7 years ago

Will do. If they (or you) let me know when they've registered, I'll approve straight away

xaviermestdagh commented 7 years ago

Thanks, unfortunately I am not in the same place than them so I don't know when.

DavidRoy commented 7 years ago

ok, I'll keep an eye out for registrations

DavidRoy commented 7 years ago

@Gary-van-Breda - please can you confirm the drupal 'roles' and configuration that need to be set for:

  1. A standard data recorder
  2. A country co-ordinator (e.g. for access to 'Country sites/walks' reports)
  3. How this relates to the transect_allocation page (http://www.butterfly-monitoring.net/transects-allocation)
xaviermestdagh commented 7 years ago

Yes indeed, for the moment I cannot see sites, walks and data created in Luxembourg by users, which would be essential for country co-ordinator.

xaviermestdagh commented 7 years ago

@DavidRoy Michelle Clemens (LU user) says she is not authorized to enter a site. Is that related to somehting on your side?

DavidRoy commented 7 years ago

@xaviermestdagh Michelle's account should now be setup. as is Kevin Jans and Marcel Hellers. Please let me know if any problems.

xaviermestdagh commented 7 years ago

Thanks, but I don't know Kevin Jans. In these cases, is it possible for me to contact him in ordre for instance to check if the protocol is followed?

DavidRoy commented 7 years ago

Yes, I'll send you his contact details

DavidRoy commented 7 years ago

@Gary-van-Breda - raising this again. Point 2 is urgent

please can you confirm the drupal 'roles' and configuration that need to be set for:

  1. A standard data recorder
  2. A country co-ordinator (e.g. for access to 'Country sites/walks' reports)
  3. How this relates to the transect_allocation page (http://www.butterfly-monitoring.net/transects-allocation)
Gary-van-Breda commented 7 years ago

A standard data recorder should be given the EBMS role "DATA RECORDER" The country coordinator should be given the EBMS role "COUNTRY MANAGER": this allows access to the "Country Sites", "Country Walks" pages. At the moment the access to the Transects Allocation page is only given to the next level up, not "Country Manager" - do I take it this is not what you require?

xaviermestdagh commented 7 years ago

Would it be possible to provide transect allocation rights to the country manager (i e for the transect of his country)?

Envoyé depuis IBM Verse

Gary-van-Breda --- Re: [BiologicalRecordsCentre/eBMS] User access to "Sites" (#33) --- De :"Gary-van-Breda" notifications@github.comA :"BiologicalRecordsCentre/eBMS" eBMS@noreply.github.comCc :"xaviermestdagh" xavier.mestdagh@list.lu, "Mention" mention@noreply.github.comDate :ven., 12 mai 2017 15:51Objet :Re: [BiologicalRecordsCentre/eBMS] User access to "Sites" (#33)

A standard data recorder should be given the EBMS role "DATA RECORDER" The country coordinator should be given the EBMS role "COUNTRY MANAGER": this allows access to the "Country Sites", "Country Walks" pages. At the moment the access to the Transects Allocation page is only given to the next level up, not "Country Manager" - do I take it this is not what you require? —You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Gary-van-Breda commented 7 years ago

OK: rights to access the transect allocation page have been given to the country managers. But - looks like there is a missing report on the warehouse, without which this page won't work:

@BirenRathod or @JimBacon : do you know when warehouse2 is going to get release 1.31.0 or later? There is a report reports/reports_for_prebuilt_forms/UKBMS/ebms_region_locations.xml that gets added in that release.

BirenRathod commented 7 years ago

Hello @Gary-van-Breda, you caught me while I was upgrading the warehouse2. please check if it has got your updates.

Gary-van-Breda commented 7 years ago

Report is present, and page now works.

Gary-van-Breda commented 7 years ago

Well it looked like it did: there is some ajax issue I'll now look into.

DavidRoy commented 7 years ago

@Gary-van-Breda

I'm not sure what 'only given to the next level up' means below. Can you explain?

The country coordinator should be given the EBMS role "COUNTRY MANAGER": this allows access to the "Country Sites", "Country Walks" pages. At the moment the access to the Transects Allocation page is only given to the next level up, not "Country Manager" - do I take it this is not what you require?

xaviermestdagh commented 7 years ago

I have now access to the "Transects Allocation" page, but

Gary-van-Breda commented 7 years ago

RE Davids comment : apologies - I have a sort of Heirarchy of access in my head... 1) Administrator 2) Country Manager 3) Normal User (Data recorder)

So the Transect Allocation was only available to the Administrators - now no longer the case. There is an issue with the saving of the allocation - I am investigating.

xaviermestdagh commented 7 years ago

@Gary-van-Breda Any progress on the saving of the allocation?

xaviermestdagh commented 7 years ago

@Gary-van-Breda Any update? Could you identify the trouble?

Gary-van-Breda commented 7 years ago

@BirenRathod : can you deploy the develop branch version of the ebms_transects_allocation form into both the EBMS and UKBMS D7 environments? https://github.com/Indicia-Team/client_helpers/blob/develop/prebuilt_forms/ebms_transects_allocation.php

BirenRathod commented 7 years ago

This has uploaded on UKBMS D7 and EBMS live site.

Gary-van-Breda commented 7 years ago

@BirenRathod : There are obviously some differences between my development environment and Live. Do you mind if we try again? Can you deploy the develop branch version of the ebms_transects_allocation form into both the EBMS and UKBMS D7 environments? https://github.com/Indicia-Team/client_helpers/blob/develop/prebuilt_forms/ebms_transects_allocation.php

BirenRathod commented 7 years ago

It has now updated. do you want me to update the report_calendar_grid.php file too?

Gary-van-Breda commented 7 years ago

@Biren I'm getting a Cross Origin request blocked when I access

http://warehouse2.indicia.org.uk//index.php/services/data/location_attribute_value

but not when I do

http://warehouse2.indicia.org.uk//index.php/services/report/requestReport

Both return json. Is there a reason for this? This also happens on warehouse1 for UKBMS.

Gary-van-Breda commented 7 years ago

The report_calendar_grid.php that I sent you should match the develop branch.

xaviermestdagh commented 7 years ago

Thanks.

xaviermestdagh commented 7 years ago

Lionel created the site RN Rosport in Luxembourg. From my account, this site is allocated to Germany, and not to Luxembourg. However, when Lionel edits this site, it is well allocated to Luxembourg... What's wrong ?!

Gary-van-Breda commented 7 years ago

Note the cross origin request block mentioned above means that the transect allocation form can only allocated people, it can not de-allocate them. Edit button: this is an issue, it should display the site. There is a URL parameter naming issue. The My sites and Country sites are very similar: the allocation is done using a different attribute, and only some people (country managers) can have sites allocated to them at a country level.

xaviermestdagh commented 7 years ago

@Gary-van-Breda Thanks for details. Regarding the site RN Rosport, why is it allocated to Germany from my login and to Luxembourg from Lionel's login? The site is close to the border, but clearly inside Luxembourg.

DavidRoy commented 7 years ago

Bumping this back to @BirenRathod

From Gary: I'm getting a Cross Origin request blocked when I access

http://warehouse2.indicia.org.uk//index.php/services/data/location_attribute_value but not when I do

http://warehouse2.indicia.org.uk//index.php/services/report/requestReport Both return json. Is there a reason for this? This also happens on warehouse1 for UKBMS.

Gary-van-Breda commented 7 years ago

@xaviermestdagh : the trouble is that the Luxembourg location record boundary is not very good: look at RN Rosport (http://www.butterfly-monitoring.net/ebms-site-details?id=413) on the map, switch off the lux topography in the layer switcher: you will see a red dashed line going through the map: this is the Luxembourg record boundary, and it very obviously does not match up with the actual boundary. This means the check thinks RN Rosprt is outside Luxembourg.

Gary-van-Breda commented 7 years ago

@BirenRathod : I also don't get a COR blocked if I use: http://warehouse2.indicia.org.uk/index.php/services/data/taxa_taxon_list

xaviermestdagh commented 7 years ago

Borders.zip @Gary-van-Breda Any idea how to fix this problem of broders? I have this shapefile of european borders if it helps...

Gary-van-Breda commented 7 years ago

We can convert the shapefile into SQL statements and upload them: the current PHP system (not Indicia) don't allow a direct upload anymore (the ability to read the file has been dropped).

BirenRathod commented 7 years ago

@Gary-van-Breda, I didn't get your comment about PHP system direct upload don't allow. I'm sure you can upload shape file into warehouse (via website). It is still supporting.

Gary-van-Breda commented 7 years ago

Sorry, my mistake - it is OK.

DavidRoy commented 7 years ago

@Gary-van-Breda @BirenRathod Where are we with this issue?

Gary-van-Breda commented 7 years ago

There seems to be 3 issues on the go 1) Edit link in Transect allocation form not working: @BirenRathod can you deploy the develop branch version of the following file into the UKBMS D7 and EBMS websites: https://github.com/Indicia-Team/client_helpers/blob/develop/prebuilt_forms/js/ebms_transects_allocation.js 2) Cross Origin request issue: This is still outstanding, and will need to be sorted by someone like @BirenRathod 3) The boundaries of the countries are not accurate enough: see new zip file given by @xaviermestdagh above. I haven't had a chance to look at this. I'm not sure what this comes under or who should deal with it - there was another issue aised (now closed) about uploading the country boundaries.

BirenRathod commented 7 years ago

Hello @Gary-van-Breda

  1. This has updated now.
  2. Where do you see Cross Origin request? send me some more details.
  3. I just tried to access through QGIS and no luck. Any idea?

Biren

Gary-van-Breda commented 7 years ago

1: Form configuration setup on EBMS and UKBMS - now works. 2: I'm using Firefox. Log in to site as eother admin or a country manager: go to transect allocation form (My Data->Sites->Transects Allocation). On the page, select Normal User Assignment; Country Luxembourg: Site "GvB Test Site Lux 1", user admin, and then press the search. When you deselect the checkbox on the admin user row, it will uncheck and send a data request to the warehouse to fetch all the location_attribute_value records that could be there - this fails the COR. It should then delete these, but that doesn't happen.

BirenRathod commented 7 years ago

Hello @Gary-van-Breda

  1. I added the value for CORS in IIS on the server now. It should be ok now.
BirenRathod commented 7 years ago

@Gary-van-Breda, I just noticed that CORS problem is exists on UKBMS too. Check on Site Assignment page. I'm resolving this now.

BirenRathod commented 7 years ago

@Gary-van-Breda, I have added value for CORS on warehouse1 too.