search

BiologicalRecordsCentre / eBMS

0 stars 0 forks source link

Site with Null value as country #46

Closed xaviermestdagh closed 5 years ago

xaviermestdagh commented 6 years ago

@Gary-van-Breda The site name "Dreiländereck" with the code "ebms:Luxembourg:90" has Null value for "Country" (when displayed using the filter of the Transect Allocation tool). If I did not compare the total number of sites from "Country sites" and "All Sites", I could not discover that this site was existing (because not visible when selecting "Luxembourg" in the Transect allocation tool). What are the circumstances that leaded to that situation for that site? Is that fixable?

Gary-van-Breda commented 6 years ago

I think the problem here is that, even with the improved country boundaries, this site is outside the Luxembourg country location record - this can be seen from the red dotted boundary line. We could add a buffer around the country boundary when checking if a site is within a country - I think 100m would work. What do you think?

xaviermestdagh commented 6 years ago

Yes if easy for you to set up, but isn't it going to allocate German/French/Belgian sites to Luxembourg?

From: Gary-van-Breda notifications@github.com To: BiologicalRecordsCentre/eBMS eBMS@noreply.github.com Cc: xaviermestdagh xavier.mestdagh@list.lu, Author author@noreply.github.com Date: 20/12/2017 12:04 Subject: Re: [BiologicalRecordsCentre/eBMS] Site with Null value as country (#46)

I think the problem here is that, even with the improved country boundaries, this site is outside the Luxembourg country location record - this can be seen from the red dotted boundary line. We could add a buffer around the country boundary when checking if a site is within a country - I think 100m would work. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Gary-van-Breda commented 6 years ago

Yes it would, if there were any!

Other options: change the way the page works, so it looks up the country attribute on the location record rather than check if it is within the boundary? This is more work to do.

We could display the code and/or the country attribute on the table for each site.

xaviermestdagh commented 6 years ago

We hope more BMS are going to join, and of course this issue is not Luxembourg specific... @DavidRoy If recorders select the country (including regional BMS!?) in a dropdown list during the creation of the site, wouldn't be great to use this value as a reference? @Gary-van-Breda How much additional work would it require?

Gary-van-Breda commented 6 years ago

Probably half a day

Gary-van-Breda commented 5 years ago

I think this has been overtaken by the changes done to EBMS in the conversion to ABLE. No longer applicable: the site in question is now within the Luxembourg countrie location record boundary. It is now possible to assign a site to a country, even if it is outside the boundary (admittedly with a warning). Bouncing to Xavier to review and hopefully close.

xaviermestdagh commented 5 years ago

I didn't face this trouble again, assuming now ok as well.