Open kitenetter opened 1 year ago
A few thoughts and questions @kitenetter.
Additional comments
OK, I'll proceed on that basis then, with the proviso that you might yet review where the metadata about reasons for keeping the records private will go.
Coding for recordsMover control now done.
Noting work in progress - I've configured a new website registration on the warehouse, ID 152 (iRecord unshared data). This has a survey datatset, ID 719 (iRecord unshared imports) which is a clone of the iRecord import survey dataset so that records can be freely moved between the 2 datasets.
Website ID 152 is configured to allow verification but not public reporting on iRecord.
On both live and test there are now the following pages, all accessible to verifiers only but not yet in the menu:
Once the code for the recordsMover component is released it can be added to the explore unshared records page which completes the functionality required for this task.
The records mover button (Share records button) is now available for testing at https://test-brc-irecord.pantheonsite.io/explore/my-unshared.
Can we add a clone of survey ID 90, "iRecord Moths", to the unshared data website. I don't think we need any others in the short-term, although it may be that other recording schemes will request additional options in future.
Have just done a test upload into the unshared data website. All seemed to go well.
On page /explore/my-unshared the "View record details" button currently leads to a "Page not found" result, but I assume the plan is to replace this with the "/record-details/verification" option on the button?
Arguably we could disable the "View species details" button, since that page won't include the unshared records, but I guess it could still provide useful context so probably best to keep this one.
I think we need to add an "Edit this record" button on the Explore page (unless a different approach to editing is needed for the unshared records).
When I did a download of records using my verification role, the unshared records were not included in the download - not sure if this is part of the process that hasn't yet been implemented.
Questions regarding the records mover button:
The records mover button has a configuration containing a list of source website/survey IDs and their matching destination website/survey IDs so that the records can only go from the 2 surveys in the unshared website to their matching surveys in the iRecord website - so there is no choice and no chance the user can move the records to an incompatible survey.
Agree about the last point - how do you see this working?
Don't know how feasible this is, but suggest:
Only other alternative I can think of is to design a new grid for the "Explore my unshared" page, which is structured to show the sample-occurrence hierarchy, and perhaps only allows complete samples to be filtered and selected for moving?
Something along these lines would definitely be desirable, but I don't think it stops us making the new features available as they stand (one we have guidance in place).
@kitenetter offering an alternate view that lists all the samples for the selected records, then allows you to expand and view the occurrences sounds feasible. Or this alternative view could just be a reload of the same occurrences explore page, but filtered to show all records from the selected samples. The difficulty here would be that the filter would have to work by passing a list of sample IDs to the Elasticsearch query. We'd need to do some tests on the upper likely limit as the list of sample IDs - do you have a feeling for the largest likely number of records in a transfer?
I don't really have a feeling for the scale of this. It's not yet clear how many verifiers will actually want to use a non-shared area, and of those that do it is very hard to know how many records they might upload, and how many samples that will translate to. Sorry!
I wonder if implementing a potentially tricky samples based solution is best avoided until we have a clearer picture of how this is going to be used. The current solution does work as it is, so maybe the documentation can explain that the records move can only work if the samples are complete. If this turns out to be a regular issue, then we can write code which shows all offending samples in a grid with the ability to expand to view the occurrences, and move all samples across, or a single selected sample.
@kitenetter any thoughts on where to go with this?
The requirement is for verifiers to be able to upload records that cannot be shared other than for verification. Use cases:
Suggested approach:
Additional item (that may need to be transferred to a separate issue):