Open johnvanbreda opened 4 months ago
A first drop of code for this is now in the develop branch - I fully expect it will need further work.
Question 1. I've implemented a check for attempts to edit records in samples that contain other records. If this happens the user is offered an option to cancel, or proceed which will result in the samples being cloned and the edited records moved to the clones before they are altered, so the other records are unaffected.
@johnvanbreda sorry for being slow to respond to this one. The above all sounds good. To respond to your initial questions:
I think you've already dealt with this.
For now at least, just for users to edit their own records. If a verifier has a need to impose a bulk verification they can contact iRecord support and we can masquerade as the relevant user if necessary (and assuming that all parties agree).
Yes, but not needed at the moment.
Arguably an extensive preview is not needed, because if a bulk edit is done and then realised to be incorrect, a reverse bulk edit can be applied to change back again. If possible it would be good to have a summary that says "W records will have field X changed from Y to Z".
Verification status I assume that any such edits will result in the record being set back to pending? This may be problematic but we can add a warning to users not to edit verified records unless absolutely necessary.
Verification status - yes, altered records will be reset to pending as normal (though I suppose I could code it not to do this - but that doesn't sound like the right solution). I can add a warning to the popup. Is it worth the extra effort of doing a pre-check to see if the records about to be altered contain any that are not currently pending, so the warning only appears when relevant?
Regarding the preview, note that a bulk edit can be performed on a range of different values in one dataset, so an undo bulk edit is not going to work. The dialog currently shows the number of records about to be fed into the bulk update, but only those which have got different values will actually be updated, so a preview could be useful (though is extra effort).
Support for large scale editing of records, e.g. for corrections to grid refs or dates following uploads. Thought needed on what fields should be editable and by whom, plus options for audit trail or undo.
The initial scope will only allow editing of the following fields:
@kitenetter a few questions:
An undo feature would of course add considerable complexity.