BiologicalRecordsCentre / plantportal

Focused repo for the Plant Portal website
0 stars 0 forks source link

"My samples" label/page when project admin #35

Closed sacrevert closed 2 years ago

sacrevert commented 2 years ago

For user "Sarah Shuttleworth" and project group_id=2134 the user is a group admin, so the text link My samples on the "My projects" page, and here on the actual "my samples" page (https://plantportal.ceh.ac.uk/my-samples-npms-mode?group_id=2134&implicit=f) should these actually be labelled "All samples", as I assume they display all the project samples rather than just the admins?

andrewvanbreda commented 2 years ago

@sacrevert The way this currently works is they do get the "My Samples" page. This would be difficult to alter, as the project permissions are designed so that admins for projects can see everything. I could perhaps remove than link if the user is detected as a website administrator (as opposed to a project administrator)

There is an All Samples link, but it is currently called "Samples administration". I could change this easily for new projects if you wanted, but I think changing it on existing projects would need a database hack.

Let me know your thoughts having read these notes (or close the issue if you are happy)

sacrevert commented 2 years ago

Happy to close if labelling is accurate. Not worth changing I think