added simulate data function

[drnickisaac]

and a few other minor changes

[AugustT]

Turns out that blank line in the description file was significant! @drnickisaac

* checking for file ‘./DESCRIPTION’ ...Error : contains a blank line

[drnickisaac]

@AugustT I think this is ready to merge, but I defer to you.

[AugustT]

Thanks for the nudge. You will see that travis has failed. If you click through and scroll down the logs you will see that the tests fail. If you are not sure how to do this we should go through this together as you have had this problem a couple of times now. I assume you did not run the tests on your PC else you would have seen this already. Running tests locally first is a good idea.

 `... <- NULL` threw an error with unexpected message.
  Expected match: "It looks like you have years with no data. This will crash BUGS"
  Actual message: "There are no visits in years 2018. This will crash BUGS"

I assume you have made an edit to the error message given when the data has missing years. It looks like you have updated it to specify the year, nice touch! You will need to update the test to reflect this change. The line to change is here:

https://github.com/BiologicalRecordsCentre/sparta/blob/a8a3d0063e2d384af2332b02e417bad163170a6d/tests/testthat/testoccDetFunc.r#L72

[codecov-io]

Codecov Report

Merging #122 into master will decrease coverage by 0.65%. The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   40.34%   39.69%   -0.66%     
==========================================
  Files          79       81       +2     
  Lines        2694     2766      +72     
==========================================
+ Hits         1087     1098      +11     
- Misses       1607     1668      +61

Impacted Files	Coverage Δ
R/simOccData.R	0% <0%> (ø)
R/detection_phenology.R	0% <0%> (ø)
R/getBugsData.R	85.71% <100%> (ø)	:arrow_up:
R/formatOccData.r	63.88% <50%> (-0.82%)	:arrow_down:
R/errorChecks.r	72.8% <60%> (-0.54%)	:arrow_down:
R/occDetFunc.r	77.62% <87.5%> (+0.73%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9acfd05...1517f64. Read the comment docs.

[AugustT]

@drnickisaac Checking in on your progress... do you need help?

[drnickisaac]

Ok - I tracked this down. The problem was that I created a more informative error message, but didn't update the test. I have to now edited the test function and further improved the error message. I've now tested this locally and confirm it passes. So this should pass on Travis next time I push.