Double centering of Julian Date

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses

http://biologicalrecordscentre.github.io/sparta/index.html

MIT License

21 stars 24 forks source link

Double centering of Julian Date #123

Closed drnickisaac closed 5 years ago

drnickisaac commented 5 years ago

@GPowney and I just discovered that we're inadvertently centering the Julian dates TWICE not once.

Line 161 of formatOccData taxa_data$Jul_date <- taxa_data$Jul_date - 182

Line 58 of getBugsData JulDate <- occDetData$Jul_date - 182

Whilst trivial to delete one of these, we should think first about which is most sensible to get rid of. Also, depending on which we use, it may be sensible to rename it as cJulDate, to indicate that it's been centered.

drnickisaac commented 5 years ago

I have fixed this by commenting out the "- 182" on line 58 of getBugsData. The broader issue is now dependent on how we deal with #119 so I will close it here.