Update dataDiagnostics for tests and naming conventions

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses

http://biologicalrecordscentre.github.io/sparta/index.html

MIT License

21 stars 24 forks source link

Update dataDiagnostics for tests and naming conventions #136

Open AugustT opened 5 years ago

AugustT commented 5 years ago

This function is still using the term time period, is that okay?

The testing has pretty poor coverage of this function

https://codecov.io/gh/BiologicalRecordsCentre/sparta/src/master/R/dataDiagnostics.r

drnickisaac commented 5 years ago

I think this is ok. Many of the primitive methods (WSS, telfer etc) still user time_period, so I don't see a problem with including it here. But if we want to use this function in the tutorial for occupancy models, then there might be an argument for harmonizing the naming with occDetfunc