search

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

Compatibility of detection_phenology and simOccData with Julian date formulation #151

Closed JHHatfield closed 5 years ago

JHHatfield commented 5 years ago

These two functions (possibly others) do not work for the new Julian date formulation. I can look into updating these but do we need back compatibility?

drnickisaac commented 5 years ago

Ideally yes. I would like to maintain compatibility wherever possible. detection_phenology should be relatively straightforward, particularly if the out object includes an attribute stating which Julian date option has been used (I presume it's possible to fit both). simOccData is not so much of a problem, since it generates data rather than analyses it. I would be comfortable with this function using only the newer formulation.

JHHatfield commented 5 years ago

The two functions have now been updated so I will close this