search

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

plotting functions for detection diagnosis renamed #185

Closed drnickisaac closed 4 years ago

drnickisaac commented 4 years ago

I've renamed two functions and updated the documentation.

AugustT commented 4 years ago

I think you have forgotten to rename your functions here https://github.com/BiologicalRecordsCentre/sparta/blob/996d0119bd30a51db880dffa55362aaefecedab1/R/detection_phenology.R#L32 and here https://github.com/BiologicalRecordsCentre/sparta/blob/996d0119bd30a51db880dffa55362aaefecedab1/R/detection_diagnosis.R#L20

codecov-io commented 4 years ago

Codecov Report

Merging #185 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   58.71%   58.71%           
=======================================
  Files          83       83           
  Lines        2638     2638           
=======================================
  Hits         1549     1549           
  Misses       1089     1089

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 996d011...3b62004. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #185 into master will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   58.71%   58.94%   +0.22%     
==========================================
  Files          83       84       +1     
  Lines        2638     2643       +5     
==========================================
+ Hits         1549     1558       +9     
+ Misses       1089     1085       -4
Impacted Files Coverage Δ
R/plot_DetectionPhenology.R 82.75% <ø> (ø)
R/simOccData.R 100% <ø> (ø) :arrow_up:
R/plot_DetectionOverTime.R 0% <ø> (ø)
R/visitsSummary.R 93.33% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 996d011...f1e5859. Read the comment docs.

AugustT commented 4 years ago

I'm still trying to figure out the names here. They are not consistent between the namespace file and your R scripts.

I also notice you are using require within your functions. You aren't allowed to do this, you need to use the @imports tag instead https://github.com/BiologicalRecordsCentre/sparta/blob/e5d4693939dd5ecd8f5384ab87d0c926a3754bfb/R/detection_diagnosis.R#L23

AugustT commented 4 years ago

And you never need to import the package your function is a part of (i.e. sparta)

AugustT commented 4 years ago

These two functions seem to do very similar things, could they be put together in one function?

drnickisaac commented 4 years ago

Ok, I've removed all the require statements. I think the functions have been renamed as plot_xxx. Is it possible that your version includes both old and new versions (with different names)? I'd rather keep these two functions separate for now.

AugustT commented 4 years ago

Ok, I've removed all the require statements. I think the functions have been renamed as plot_xxx. Is it possible that your version includes both old and new versions (with different names)? I'd rather keep these two functions separate for now.

I think you could be right, we might have duplicates of the functions because I was trying to fix this and messed it up.

AugustT commented 4 years ago

Hmmm I just had a look at your repository to check and I'm afraid the issues are over there too. i suggest we have a sit down together to look at this:

https://github.com/drnickisaac/sparta/blob/master/R/detection_phenology.R defines plot_DetectionPhenology And so does https://github.com/drnickisaac/sparta/blob/master/R/detection_phenology.R

https://github.com/drnickisaac/sparta/blob/master/R/detection_diagnosis.R defines plot_detection_diagnosis but this is not in NAMESPACE