search

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

Fixed #218

Closed drnickisaac closed 3 years ago

drnickisaac commented 3 years ago

as discussed: to fix #217 Other changes in response to test fails & problems with the examples.

AugustT commented 3 years ago

@drnickisaac I see some errors in model builder tests. There seems to be a disagreement about whether list length should be logged or not, can you confirm either way? I should be able to fix the other issue myself.

drnickisaac commented 3 years ago

Ah yes. That's in ReportingRate. Nothing to do with Occupancy modelling. These are changes I made in response to a non-CEH user back in January. Will explore.

drnickisaac commented 3 years ago

You'll have to talk me through this error - I can't understand the Travis output and I can't remember enough about the changes.

AugustT commented 3 years ago

@drnickisaac I think the tests here need to be updated https://github.com/BiologicalRecordsCentre/sparta/blob/8451e0140bc51d775c958c4e59d90e0977e2ce1f/tests/testthat/testreportingRateModel.r#L85

drnickisaac commented 3 years ago

I cannot see where Travis is reporting this problem.

drnickisaac commented 3 years ago

@AugustT fixed problems in testReportingRate() arising from switch to log(listlength)

drnickisaac commented 3 years ago

Travis says Yes! The AppVeyor fails only on the development version of R, so I will overlook this for now. @mlogie @AugustT and I have all looked at this code in some detail. So I will take the unilateral decision to merge now without further review, in the light of urgency to get models running.