search

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

criterion is not available in occDetModel() #231

Closed drnickisaac closed 3 years ago

drnickisaac commented 3 years ago

All the options in occDetFunc() should be made available in occDetModel(), which is a wrapper for the former. I just noticed that the criterion argument is not available. There may be others. Someone should check and update accordingly. Maybe there is a way to specify that other arguments (to occDetFunc()) are optional, e.g. .....

AugustT commented 3 years ago

We could use the ellipsis, but I feel this hides the functionality a bit. I think it would be better to update occDetMod to explicitly state the pararmenters available in occDetFunc

drnickisaac commented 3 years ago

I just found further issues in occDetModel(): when calling formatOccData() is does not pass the optional new arguments closure_period and replicate

drnickisaac commented 3 years ago

I have fixed this on my local branch. Will push then create PR.