Pull requests - Githubissues

BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses

http://biologicalrecordscentre.github.io/sparta/index.html

MIT License

21 stars 24 forks source link

Pull requests #260

Closed DylanCarbone closed 5 months ago

DylanCarbone commented 5 months ago

Hi @AugustT

Key changes:

Tidied the tests of functions using the frescalo executable in the testfrescalo.r file. GHA actions will also run the tests in a windows environment instead of skipping. We need to look into whether frescalo runs in a macos environment. Comments in the old frescalo test file suggests that frescalo does not run on macos, but then I think this would have been raised as an issue.
For now I have removed testing in the 'ubuntu-latest' environment which raises errors related to the installation of lme4.
Replaced mockery::stub() function with the testthat::with_mocked_bindings() which does not alter global function configurations.

Thanks,

Dylan

AugustT commented 5 months ago

@DylanCarbone Why is appveyor still running? I'm happy to merge this, even with the minor lme4 installation bug on the old Ubuntu release, do you agree?

DylanCarbone commented 5 months ago

@AugustT, that is odd. Please see this issue here. If this is correct, the appveyor failure is actually a log of a previous failure when the appveyor yml existed. The solution they suggest is to commit directly to the repo instead of merging a pull request. This could explain why there is no such issue in the BRCindicators repo, after you made a direct edit to the read me during our last meeting.

Could you please try editing the readme file and pushing directly to the repo?

Thanks

DylanCarbone commented 5 months ago

I'm happy for you to merge, even with the lme4 installation bug. Strangely, that error hasn't occurred in my branch. It must be another random installation error.

AugustT commented 5 months ago

Okay I have removed the 'webhooks' for Appveyor which should solve that issue