BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

Gridref manipulation functions #33

Closed drnickisaac closed 6 years ago

drnickisaac commented 10 years ago

I’ve been using the Sparta versions of these two functions: It’s very handy to have these in a package, so thanks. But I've come up against some issues:

  1. gr2gps_latlon() seems to work only on individual gridrefs, and needs an sapply() wrapper to handle vectors.
  2. reformat_gr() returns hectad gridrefs when prec_out is set to 2000 or 5000.
  3. both functions seem to barf when presented with an NA.
AugustT commented 10 years ago

Thanks @drnickisaac. I am aware of these issues and @colinharrower has already fixed some, if not all of these already in his mapping package. Since @colinharrower has been working on a package containing all of the mapping functions that we use we need to think whether or not we want to keep these functions in sparta, or simply source in the BRC mapping package.

drnickisaac commented 6 years ago

Any views on this?

colinharrower commented 6 years ago

I'm pretty sure all of these issues are resolved in the versions that are in the BRCmap package