CharlieOuthwaite commented 6 years ago

Added the check for missing years back in for issue #58 and added new error checks and tests in the function test script for the new max_year parameter for issue #59 .

codecov-io commented 6 years ago

Codecov Report

Merging #67 into master will decrease coverage by 0.2%. The diff coverage is 9.09%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   32.73%   32.53%   -0.21%     
==========================================
  Files          79       79              
  Lines        2917     2948      +31     
==========================================
+ Hits          955      959       +4     
- Misses       1962     1989      +27

Impacted Files	Coverage Δ
R/occurrenceChange.r	`0% <0%> (ø)`	:arrow_up:
R/occDetFunc.r	`81.85% <100%> (+0.63%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6fbd52...08e43f4. Read the comment docs.

CharlieOuthwaite commented 6 years ago

Additional changes added to address issue #65 changes to occurrenceChange function

AugustT commented 6 years ago

Thanks Charlie I will have a look at this tomorrow, sorry for the delay!

AugustT commented 6 years ago

Merged in now. @CharlieOuthwaite can you close the issue(s) this relates to?

BiologicalRecordsCentre / sparta

Added additional error checks #67

Codecov Report