BiologicalRecordsCentre / sparta

Species Presence/Absence R Trends Analyses
http://biologicalrecordscentre.github.io/sparta/index.html
MIT License
21 stars 24 forks source link

eta.psi0 & eta.p0 in non-regional model #76

Closed drnickisaac closed 6 years ago

drnickisaac commented 6 years ago

Galina has been running ranwalk models without the regional option and getting errors.

Both eta.p0and eta.psi0 are being monitored but are not part of the model. @CharlieOuthwaite assures me these are not used for any current model - they are left over from the hierarchical centering options that are no longer used.

If so then we need to delete line 284 of occDetFunc from: if(!'sparta' %in% tolower(modeltype)) parameters <- c(parameters, "eta.p0", "eta.psi0")

And a chunk of code from line 30 of getObsModel beginning: intercept = {

This got me wondering why @CharlieOuthwaite and @GPowney have not noticed this before. It’s because these parameters are removed for regional model option (line 303 of OccDetFunc).

AugustT commented 6 years ago

good spot

drnickisaac commented 6 years ago

I've removed these in v0.1.44 (on my repo today).