search

BiomedSciAI / fuse-med-ml

A python framework accelerating ML based discovery in the medical field by encouraging code reuse. Batteries included :)
Apache License 2.0
137 stars 34 forks source link

make examples subpackage (fuse_examples) #277

Closed mosheraboh closed 1 year ago

mosheraboh commented 1 year ago

Hi @alex-golts @YoelShoshan @SagiPolaczek ! After many issues, I've changed the examples package to be be subpackage. Please carefully review - cause we can change it only once :) .

alex-golts commented 1 year ago

@mosheraboh what currently prevents "fuse_examples" to be installed (or attempt to be installed) when someone does pip install -e .[all] (no examples mode)? I don't see some sort of exclusion for it in setup.py

or the idea is it will still be created in the site-packages, but the examples code will just not work?

alex-golts commented 1 year ago

did you try to run pip install -e .[all+examples]? for some reason I'm getting an error:

pip._vendor.packaging.requirements.InvalidRequirement: Parse error at "'[all+exa'": Expected string_end
mosheraboh commented 1 year ago

Thanks @alex-golts! Can you please pull and give it another try: pip install -e .[all,examples] As for limiting a subpackage - there is no simple way (that I'm aware of) to exclude it. But the dependencies won't be installed - so you probably get an error when you try to use it.

alex-golts commented 1 year ago

Thanks @alex-golts! Can you please pull and give it another try: pip install -e .[all,examples] As for limiting a subpackage - there is no simple way (that I'm aware of) to exclude it. But the dependencies won't be installed - so you probably get an error when you try to use it.

works for me now, thanks