Firefox desktop action entries not launching

Biont / sway-launcher-desktop

TUI Application launcher with Desktop Entry support. Made for SwayWM, but runs anywhere

GNU General Public License v3.0

613 stars 29 forks source link

Firefox desktop action entries not launching #21

Closed NullSense closed 4 years ago

NullSense commented 4 years ago

E.g. [Desktop Action new-private-window] (file can be found in /usr/share/applications/firefox.desktop) does not launch with the current implementation, I tried adding new Desktop actions for launching my custom firefox profiles, but they also seem to not work.

Biont commented 4 years ago

Thanks for the report. I'm seeing the same, so I shall have a look

Biont commented 4 years ago

Got the wrong issue id in the smart commit, but I believe this is now fixed in 7cc736d5d37f33c6b07eea15c9d220dd2ee5b7c9 @NullSense Can you please check?

I hope this does not break anything, but it really looks like a regression from an earlier state of the script: The last character of the desktop action was stripped so it could then no longer be found.

If that's the case, the entire feature must have been broken for a while now ...

NullSense commented 4 years ago

That seemed to have fixed it. Thanks @Biont