Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.42k stars 212 forks source link

Saving Pictures Issue.. #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Whenever I setup everything to the best of my understanding it works up untill 
the saving... it dosn't seem to save to Individual picture files.. it instead 
just saves to one.. and with each load it replaces the other, so its blank 
named image that changes.. is there no way for it to save it with separate 
names..
_________
Windows 7 (x64) 
_________
Imgbrd-grabber version 1.7

Original issue reported on code.google.com by MrRobotN...@gmail.com on 21 May 2011 at 8:11

GoogleCodeExporter commented 9 years ago
Thanks for the report, I'll try to fix this as soon as possible. It seems that 
image saving is quite buggy since 1.7...

But can you give me more details: from which part of the program are you trying 
to save images? From the "Explore"/"Favorites" tab or from the "Download" tab 
(using image's md5/id)?
And, what have you put in the "Folder" and "Format" field in the options?

Original comment by bio.nus@hotmail.fr on 21 May 2011 at 9:17

GoogleCodeExporter commented 9 years ago
Ok, I found the problem which will be fixed in 1.7.1 version that will be 
released in a few minutes.

Original comment by bio.nus@hotmail.fr on 21 May 2011 at 9:24

GoogleCodeExporter commented 9 years ago
Now I question if what I am doing is correct, where exactly do I get the option 
to change the names for each image to be saved? Since I might not be doing it 
right.

Original comment by MrRobotN...@gmail.com on 21 May 2011 at 10:30

GoogleCodeExporter commented 9 years ago
Oh, yes, I didn't reply, sorry.
You can change the names in the "Filename" field in the "Save" tab of the 
options.

For example, to save the picture with its md5 (an unique identifier), you can 
set it to "%md5%.%ext%". You can also save these image in subfolders, like in 
"%artist%/%copyright%/%md5%.%ext%". The other tokens are described below the 
field. Then it should be saved correctly.

If not, the best thing to do is to send me directly your settings.ini file, 
wich can be found in "%USERPROFILE%/Grabber".

Original comment by bio.nus@hotmail.fr on 21 May 2011 at 10:45

GoogleCodeExporter commented 9 years ago
I cannot seem to find a "Filename" field in the "save" tab but in the 
settings.ini i found it, its "Format" but how and ever.. i used to just put 
".jpg" in it, but anyways i tried what you said up there and it didn't work, so 
anyways, heres the settings.ini
(Pastebin, 1 hour up)

http://pastebin.com/pCa7B72x

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 8:56

GoogleCodeExporter commented 9 years ago
Sorry, here it is again
http://pastebin.com/Sajhzqhc
Longer this time.. :P

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 9:57

GoogleCodeExporter commented 9 years ago
Yes, it is the "Format" field, sorry. Indeed, if you used to just set it to 
".jpg", it will just generate files named ".jpg". I'll rename it in the next 
version to avoid further comprehension problems (plus add something to check 
format's validity).

"%artist%/%copyright%/%website%/%ext%" will not give valid filenames, since it 
will create a file named using extension only (%ext%), like just "jpg" or "png" 
(content of the %ext% token) which will not be openable (unless you rename it 
to "something.jpg").
To get valid filename, you must put something before the extension, like 
image's md5 hash (since it is unique for each image, each file will be unique):
"%artist%/%copyright%/%website%/%md5%.%ext%"

And if it stills doesn't work, you can try using just "%md5%.%ext%".
Thanks for your patience.

Original comment by bio.nus@hotmail.fr on 22 May 2011 at 6:09

GoogleCodeExporter commented 9 years ago
Unfortunetly "%artist%/%copyright%/%website%/%md5%.%ext%" Dosnt work, but 
"%md5%.%ext%" works! And since it works im happy, thank you for your time in 
the creation of this program and helping me out!! Thanks again! :D

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 6:48

GoogleCodeExporter commented 9 years ago
Ah, I'm glad to hear that it is working for you finally! :D
You're welcome, thanks to you, some problems about options have been 
highlighted, so I'm going to remake them from scratch, to make them clearer.

PS: "%artist%/%copyright%/%website%/%md5%.%ext%" doesn't work? That's strange. 
Using your settings file, I can have it to save images properly with this.

Original comment by bio.nus@hotmail.fr on 22 May 2011 at 6:54

GoogleCodeExporter commented 9 years ago
Well it seems to work, then it hangs, crashes and i guess that means it dosnt 
work, ill retry after its finish downloading, also might i ask the possibilty 
of this program downloading the entire database of images? or is that exactly 
what its doing? (cause if so, awesome :D)

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 7:06

GoogleCodeExporter commented 9 years ago
Aw, I'll make deeper tests then.

You want to download the entire database? You know that's a lot of pictures 
that takes a lot of space! But if you want to do this, I think you can add a 
batch download leaving the tag field blank, starting at page 1, and setting the 
image limit to something like 825871 (number of images on danbooru currently).
But this can take a lot of time, and if anything happens, that would be really 
awful.

Original comment by bio.nus@hotmail.fr on 22 May 2011 at 7:17

GoogleCodeExporter commented 9 years ago
Well, if anything happens, redo cause its working :D which is a good thing, 
better to have it working then not at all, but ill be honest >.> <.< I kinda 
made one of my friends make a type batch downloader i guess for another site, 
that downloaded the entire database, was like 2gb or so, but yea kinda 
collection :3

PS: Need anyhelp with testing? I'll be glad to help! 

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 7:21

GoogleCodeExporter commented 9 years ago
Another side note, If the entire databse is 88773 up and I had it as you said 
up there, Page one, image limit, should 34% be only 35 pictures? D:

Original comment by MrRobotN...@gmail.com on 22 May 2011 at 7:37

GoogleCodeExporter commented 9 years ago
Yes, it seems quite strange, I think that batch download doesn't work any more 
then (urk). Ok, I'm working on this now and I hope I'll be able to release a 
fix for this quickly.

PS: thanks for your proposal, but I think we can say that this is already what 
you are doing, testing the program and reporting bugs :D

Original comment by bio.nus@hotmail.fr on 22 May 2011 at 7:58

GoogleCodeExporter commented 9 years ago
Ok, I hope this will be fixed for you in 1.7.2 (I've only downloaded first 1000 
images)
But for the moment, you can only download images up to the 100000th image 
(trying downloading more would be a waste of time), since there is a protection 
after the 1000th page (and since you can get up to 100 images par pages: 
100*1000=100000). Will be fixed later (this week, maybe Tuesday or Wednesday), 
I don't have the time to do this tonight, sorry (my bed's calling me :D).

And thanks again for your patience.

PS: if you can't wait for downloading all images, you can use others softwares 
listed on the project page, but they don't have as possibilities than this one.

Original comment by bio.nus@hotmail.fr on 22 May 2011 at 10:20

GoogleCodeExporter commented 9 years ago
Just asking, does "%artist%/%copyright%/%website%/%md5%.%ext%" work now? Would 
be alot easier to search ect, also whats with the "/"'s and that one "." :3

Original comment by MrRobotN...@gmail.com on 24 May 2011 at 5:09

GoogleCodeExporter commented 9 years ago
Uh yes, totally forgot, that, indeed it seems that it doesn't work in batch 
download (in single image download it works though). I'll upload 1.7.3 to fix 
this soon (in about 10 minutes).

And I don't get your question about the "/" and ".". The "/" symbolizes 
sub-folders and the dot is in the filename, before extension.

Original comment by bio.nus@hotmail.fr on 24 May 2011 at 5:23

GoogleCodeExporter commented 9 years ago
XD I litterly just realised what the "/" and "." was as you responded.. Also it 
seems to be working now :D downloading over 1000 for a test, at like 400 and 
still 0% :P Better then it telling lies! :D

Original comment by MrRobotN...@gmail.com on 24 May 2011 at 5:25

GoogleCodeExporter commented 9 years ago
I knew the way the program calculates percentage is not very efficient, but 0% 
for 400/1000, it's even worse than I thought. What are you downloading?

Original comment by bio.nus@hotmail.fr on 24 May 2011 at 5:31

GoogleCodeExporter commented 9 years ago
Pictures duh :P but if you mean from what site, Konachan, or if you meant oh 
sorry -.- over 1000, its 88888 -.- Sorry.

PS: Chances of this program being able to download Shimmie type image boards?

Original comment by MrRobotN...@gmail.com on 24 May 2011 at 5:34

GoogleCodeExporter commented 9 years ago
Why not. Do you have an example of shimmie-based imageboard?

Original comment by bio.nus@hotmail.fr on 24 May 2011 at 5:36

GoogleCodeExporter commented 9 years ago
I do but im part ashamed to tell it.. meh www.tentaclerape.net :P they used to 
have all the images stored in /images/ but seem to finally blocked it :l

Original comment by MrRobotN...@gmail.com on 24 May 2011 at 5:38

GoogleCodeExporter commented 9 years ago
Nop', working on this then. :)

PS: 1.7.3 uploading...

Original comment by bio.nus@hotmail.fr on 24 May 2011 at 5:49

GoogleCodeExporter commented 9 years ago
For some reason, "%artist%/%copyright%/%character%/%md5%.%ext%" dosnt work for 
me at all, I forced my friend to try the program using said commands, and it 
works for him, and it clearly works for you. So I havent a clue D:

Original comment by MrRobotN...@gmail.com on 25 May 2011 at 6:21

GoogleCodeExporter commented 9 years ago
Yes, "%artist%/%copyright%/%character%/%md5%.%ext%" is actually working for me. 
Have you tried to delete C:/Program Files/Grabber then to reinstall the latest 
version of the program?

What do you mean by "doesn't work at all"? Images aren't saved?

Original comment by bio.nus@hotmail.fr on 25 May 2011 at 7:23

GoogleCodeExporter commented 9 years ago
It acctually crashes, ill try the deleting thing..

Original comment by MrRobotN...@gmail.com on 25 May 2011 at 7:24

GoogleCodeExporter commented 9 years ago
Looked as if it was working, then it crashed :L any ideas? "Grabber.exe has 
stopped working"

Original comment by MrRobotN...@gmail.com on 25 May 2011 at 7:35

GoogleCodeExporter commented 9 years ago
When does it crashes precisely? When trying to save a picture? (single or 
batch?)
Another possibility is that there is a problem with a file in your Grabber 
folder ("%USERPROFILE%/Grabber"), try renaming it to something like 
"Grabber.old" then retry. If it still doesn't works, then the problem comes 
from somewhere else, and I'll have to do some investigations :P

PS: tentaclerape.net will be added in next release, I hope tonight.

Original comment by bio.nus@hotmail.fr on 25 May 2011 at 7:42

GoogleCodeExporter commented 9 years ago
:O Works! :D And i'll be looking forward to tonight! 

Original comment by MrRobotN...@gmail.com on 25 May 2011 at 7:50

GoogleCodeExporter commented 9 years ago
1.7.4 uploaded, sorry for the wait :p

The problem with this booru it is that you can't get more than 16 images a 
time, so even if you set your limit to 100, you'll get only 16 images anyway.
Also, if you want to batch download images from it, you must set "images per 
page" to 16. Leaving this to 100 will not give the desired result. For example, 
if you leave it to 100 and set limit to 50, it will only get 16 images, and if 
you set limit to 200, it will only get 32 images.

I'll try to find a solution to this soon.

Original comment by bio.nus@hotmail.fr on 25 May 2011 at 9:43

GoogleCodeExporter commented 9 years ago
Another thing, does %all% work in the "format" field? as in if i had 
"%website%/%all%/%md5%.%ext%" Should I have one folder from that site then more 
folders with tags then a Md5 picture? Just wondering if thats what I am todo 
with %all% if it is, D: Not working :P

Original comment by MrRobotN...@gmail.com on 26 May 2011 at 9:12

GoogleCodeExporter commented 9 years ago
"%website%/%all%/%md5%.%ext%" will give you something like 
"danbooru.donmai.us/akemi homura black hair black legwear bow dress gun 
hairband kobayashi chisato long hair mahou shoujo madoka magica pantyhose 
pistol purple eyes ribbon serious shawl solo 
weapon/bbb12c368ac395f9cc69a5f1d7317a20.jpg"
%all% will be replaced by all the tags (without underscores), separated by the 
separator set in the options. It can be useful for searches, but since Windows 
have a filename-length (same thing with dirs) limitation, when there is too 
much tags image won't save. Thinking about it, I will modify this behavior in 
next release and make program automatically reduce filename-size.

So I can say that %all% is working, but can still be improved :P

Original comment by bio.nus@hotmail.fr on 26 May 2011 at 9:28

GoogleCodeExporter commented 9 years ago
I think we can say that this issue is fixed :p
And %all%'s behavior has been fixed (now it limits filename length).

Original comment by bio.nus@hotmail.fr on 19 Jun 2011 at 10:20