Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

Some Bugs (ver 3.1.4) #108

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 9 years ago

Yo! Long time no chat! :D

Operating System: Windows 7 - 32 bit

So I have discovered some issues while using grabber:

Very Minor Issue: Version is still listed as 3.1.3 at About Grabber. Crashing: Still crashes sometimes when I change download folder source on the options window. Crashed once while searching on tag browser with the default sources checkboxes checked.

Bugs

Ex. I searched the tag Hidari on zerochan.net. According to zerochan.net it has 215 images related to the tag.

  1. Grabber seems to show it correctly, showing a total of 215 images when i try to scan the tag with it. (I put 1000 images for the images per page and pressed ok)(picture2)
  2. So as you can see currently it says "Page 1 of 3 (100 of 215)."(picture2)
  3. So seeing this, I press get all. Here comes the problem.
  4. So I see the download page. The info is displayed correctly (215 images), but when I pressed download it only downloads 100 pictures. It also missed some pictures that were shown on the tag browser. (picture4)
  5. I tried to work it out with get this page instead:
  6. So I search "hidari" again.
  7. I put 1000 images for the images per page and pressed ok)
  8. So as I can see again it says "Page 1 of 3 (100 of 215)."(picture2)
  9. I press get page, then pressed the button on the bottom right of the program that lets you go to the next page. I did the same and pressed get this page on the other pages.
  10. So when the three pages were done I go and see this on the download page. Page 1 :100 images Page 2: 100 images Page 3:15 images. I figured out everything was okay, so i pressed download.(picture3)
  11. So page 1 and 2 both downloaded 100 images, although Grabber missed some of what it scanned on the tag browser. The problem lied on page 3, the one with the 15 images. The program didn't download the images on the page that it scanned-- instead it downloaded the same number of images that were located on the first page/other pages(some other images on the first page instead of images 200-215 on page 3.)(picture5 and picture7)
  12. Also to note, that the tag browser kind of malfunctions somtimes when going to the next pages: Ex: Page 3 of ? (15 of ?)First page looks okay though. (shown in picture5)
    • When searching with images limit below 100, the first page will still show 100 and then when shifting to the next page, the program will subtract the images shown on the next page with the number that is inputted on the images per page textbox.

Ex. searched hidari with 99 images per page.

Sorry for the wall of text man :( I attached some images for your reference :D)

Original issue reported on code.google.com by yukinr...@gmail.com on 5 May 2012 at 9:54

bug1.JPG picture2.JPG picture3.JPG picture4.JPG picture5.JPG picture6.JPG picture7.JPG

GoogleCodeExporter commented 9 years ago
Wow, that's a big post :D
First, thanks for taking the time to write it and make all the screenshots.

> Very Minor Issue: Version is still listed as 3.1.3 at About Grabber.
Yeah, I forgot this when releasing the last update, and since it is a very 
little problem, I didn't make an update just for this.

> Still crashes sometimes when I change download folder source on the options 
window.
That's strange. Does it crash when you close the options window or when you try 
to save an image? And when it crashes, have you changed the folder's source 
drive? (C: to D: for example)

> Crashed once while searching on tag browser with the default sources 
checkboxes checked.
Should have been 3dbooru (behoimi) that was checked then. No idea where it 
could come from though, I'll check this in more details.

> Issue #1: Changing the download folder location on the options mini window on 
the browser does not change the download location on the main options window. 
(and im not sure if it also changes the download folder location.)
That's not really a bug. Unless you click the save button, the new path and 
filename are just temporary changed and will not be saved when the program 
stops. Changing these values on the options window will save them definitely. 
It is like the "+" part on the search tabs: you can change the images/page 
value (for example) but it will not be saved unless you change the value 
directly in the options. I don't know if it is really clear (if it's not I can 
try to re-explain more clearly if you want), but it's not a bug. :)

> Issue #2: After downloads, when changing download folders then redownloading 
grabber will still skip the images and mark the images as existent even though 
the images do not exist on the folder. Deleting the download session and 
restarting the program fixes this issue though.
It is a bug in a bug in fact :X
I found a solution to fix it in the 3.1.5 update. :)

> Issue #3: Filesizes are not being displayed properly. (bug1)
Yeah, zerochan, unlike danbooru does not provides directly the filesizes. I'll 
fix this in the 3.2 version since it implies changing quite a few things.

> Issue #4: Some images are missed when they are downloaded, even though the 
pages are being scanned correctly by Grabber.
So you mean the download window shows the right number of images, but at the 
end of the download there are some images missing? Is there any error while 
downloading or anything?

> Issue #5: Get this page/Get all kind of randomly malfunctions (at this source 
only at least.)
Zerochan returns a fixed number of images per page, you can't change the value 
of images per page to something else than 100. So when you do a batch download 
with it, make sure to have a value of images/page set to 100. So in your 
picture 2 you should have images per page = 100 and images limit = 215. I 
forgot to make the program do it by itself in the 3.1.4 update, it should 
automatically set the images per page value to 100 in the next version.

> When searching with images limit below 100, the first page will still show 
100 and then when shifting to the next page, the program will subtract the 
images shown on the next page with the number that is inputted on the images 
per page textbox.
It is for the same reason as earlier: you can't put any other limit than 100 
images/page for the moment on zerochan. It is a feature I'll add in the 3.2 
version ^^

To summarize, I'll try to fix most of what you said in he next update.
Thanks again for taking the time to write all this. :)

Original comment by bio.nus@hotmail.fr on 8 May 2012 at 4:56

GoogleCodeExporter commented 9 years ago
>  Issue #4 : Some images are missed when they are downloaded, even though the 
pages are being scanned correctly by Grabber.
 > I had no problems/errors on the download phase :) The closest description that i can give on what's happening is that Grabber is kind of "mismatching" what it needs to download and tries to redownload images that are downloaded already on page 3(picture 5 and picture 7) while when downloading on the other pages (1 and 2) it misses some pictures (I confirmed that it misses one on page 2 every time that i redownload). (Tag used: hidari)

> Still crashes sometimes when I change download folder source on the options 
window.
> It crashes often when I close the options window after changing the download 
path within C:. It's kind of random though-- Sometimes it happens, sometimes it 
doesn't. :) I'll try and see if it crashes when changing drives and try to 
reproduce the crash.

Original comment by yukinr...@gmail.com on 8 May 2012 at 6:05

GoogleCodeExporter commented 9 years ago
More on Issue 4:
It doesn't download the images seen on the page, instead it downloads the same 
number off another page. (picture 5 and picture 7)

Original comment by yukinr...@gmail.com on 8 May 2012 at 6:07

GoogleCodeExporter commented 9 years ago
More on  Issue 4 :
Strange, it downloads everything when I batch download.

Original comment by yukinr...@gmail.com on 8 May 2012 at 7:29

GoogleCodeExporter commented 9 years ago
Congrats on fixing the big memory leak! ^^ Here's a few general things I 
noticed about the new version:

In Options -> Interface, the bottom-most checkbox ("Telecharger les pages...") 
and the explanation below are displayed in French on the English version. I 
assume this is the new "Get this page" behavior setting?

I'm still experiencing a crash every time I try to use the image viewer. When I 
first installed v3.1.4 it worked correctly for one image, but would freeze a 
few seconds into loading the 2nd or 3rd image (whether I closed the previous 
window or left it open). Now it has progressed to freezing immediately upon 
opening the first window in a session, before it loads any of the image. Tried 
a fresh install on a new computer and it took around 4 image views to crash.

I had some trouble when I installed this on a system I've never run a previous 
version on. The board (source) list was completely empty, and the dropdown with 
the board styles was empty too, so there was no way to add boards. I copied the 
user\grabber\sites\ directory from my main computer, and everything seemed to 
behave as expected. 

Also, after a virgin installation, a 'first setup' dialog appears asking for a 
filename mask and download location. However, the entries appear not to be 
saved to the settings, as both fields are still blank after this screen. It 
occurred to me that this popup might be confusing to new users, if they are 
asked to enter a filename mask without the benefit of a reference list like 
appears in the options menu, and may also be a bit redundant with the same 
settings displayed prominently on the main screen. Maybe the Options -> 
Filename screen could popup on first run, instead? 

And while I'm on the topic, I'll mention that I too found the "save" button on 
the main-screen file settings to be a bit awkward at first, too. Even after I 
discovered by error that it was necessary, I still forgot to do it several 
times (and made a mess out of a couple of my directories, lol). It might be 
more intuitive if the settings simply applied after typing or making a folder 
selection, and the Reinitialize button could perhaps be changed to revert back 
one or more changes made that session? Just an idea ^^

Original comment by PhotonB...@gmail.com on 17 May 2012 at 7:32

GoogleCodeExporter commented 9 years ago
> Congrats on fixing the big memory leak!
Thanks. It was no big deal fixing it, but I admit I had a hard time finding 
where it came from :D

"Télécharger les pages non chargées" is indeed the option to fallback to the 
previous "Get all"/"Get this page" buttons behavior. If you check the box, 
it'll take into account even non-loaded modifications.

About the image viewer, I admit there are random crashes (urk), but "every 
time" is still way too much. On a clean installation, I don't have any crashes 
until I really try to make it crash by opening dozens of window and randomly 
changing pages/opening new tabs/etc. What boards are you using when it crashes?

For the empty list of boorus, it indeed comes from that folder. What version 
caused that problem? All installers should normally generate the 
user/Grabber/sites folder and its content. Maybe there was an error during the 
download and the installer got compromised? I don't think it is even possible 
though. :/

About the first launch dialog, indeed it doesn't works at all o.O
Seems like I totally forgot to update it when I added the change filename/save 
folder dock, and it doesn't do anything anymore... Your suggestion to just open 
the Options sounds good to me, I'll just do that now, it'll be less annoying, 
and there will be the explanations.

Same thing for your second suggestion. Saving this value when the program 
closes, but still having a "revert" button is a good idea too.

Original comment by bio.nus@hotmail.fr on 17 May 2012 at 11:31

GoogleCodeExporter commented 9 years ago
>>but "every time" is still way too much. On a clean installation, I don't 
>>have any crashes until I really try to make it crash by opening dozens of 
>>window and randomly changing pages/opening new tabs/etc. What boards are you 
using when it crashes?

Well, it's happening with every board I've tried: gelbooru, e621, safebooru, 
wildcritters, zerochan, etc. I just re-confirmed this on 3 different computers, 
2 running win7 and the other XP, all with different owners and setups, and both 
with upgraded and fresh installs of grabber, with default and altered settings. 
The only slight variance is that sometimes with a fresh board it takes 3-5 
images to crash, but within 2-3 restarts it's the first image, like the others 
(though this only happens on 2/3 systems). I don't have any ideas about why 
this happens to me with 100% consistency and to you only rarely, but the 
variance in my setups leaves me at a loss to suggest how this could be the 
result of something unique to my system.

>>What version caused that problem? All installers should normally generate the 
>>user/Grabber/sites folder and its content. Maybe there was an error during 
the download 
>>and the installer got compromised? I don't think it is even possible though.

All this is with v3.1.4, and the empty board problem happened on a brand-new 
Presario/win7 that is basically stock from the store. I just did a fresh 
install on my XP laptop, and the board list generated fine. So maybe it had 
something to do with the default windows firewall? Or maybe the wacky and vague 
windows 7 permissions system. I'll do some more tests when I have a little more 
time. ^^

Original comment by PhotonB...@gmail.com on 22 May 2012 at 6:53