Not downloading indicated files...

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.

https://www.bionus.org/imgbrd-grabber/

Apache License 2.0

2.55k stars 216 forks source link

Not downloading indicated files... #1241

Closed mlmmt3 closed 2 years ago

mlmmt3 commented 6 years ago

What steps will reproduce the problem?

Attempt downloading from danbooru with various combinations of tags (always more than 2)

What is the expected behavior? What do you get instead?

Tags: width:>1000 height:>1000 date:>2018-01-26 ratio:16:9..10 search returns correct images, but when it downloads, instead of the images indicated in the search panel, grabber appears to attempt to download everything...

How often does this problem occur? On which sources?

Danbooru, whenever attempted

What version of the program are you using? On what operating system?

5.5.2 windows 10 x64

Please provide any additional information below

mlmmt3 commented 6 years ago

I just went and tested, and it seems no matter what tags I put in, the search results come up correct, but the program appears to just start from the most recent danbooru post and start downloading, which is really strange....

After restarting the program a couple times, seems to be working correctly for the moment... it seemed to be stuck attempting to download all of danbooru, reguardless of what I actually asked it to download... (even tried to download from yande.re and it just tried to download all of danbooru again for some reason)

After about 2 hours of messing around, it seems that the program is having some strange issues (it is somehow finding far different amounts of results compared to actual website... something is parsing wrong)

Bionus commented 6 years ago

So, from what I understand, if you search more than 2 tags (which is the limit for free users on Danbooru):

When browsing: it works properly and show relevant results
When batch downloading: it somehow downloads all images without taking the input tags into consideration, starting from the latest image and trying to download all of Danbooru's images

I get that you're using a premium/gold account (or whatever it's called) on Danbooru?

One reason could be that Grabber fails to login during batch downloads, but in that case the Danbooru API should return an error instead of fallbacking to showing all images:

XML: <result success="false">You cannot search for more than 2 tags at a time</result>
HTML: You cannot search for more than 2 tags at a time

mlmmt3 commented 6 years ago

Yeah, you would think, except it actually does work... sometimes though the amount of images it downloads... often makes no sense... it somehow downloaded 1,401 images (including a number of duplicates) from a search that should only return 1,140 results... Also, it might have something to do with the fact that I am using a bunch of complicated tags that each have variables attached to them... (and all the downloaded images matched the search parameters easy enough to tell when the string is a bunch of specific dimension rules and a date rule)

(and yes, I have a Platinum account, which leads to all sorts of fun with downloaders because I can use up to 10 tags in a string when searching, which breaks all sorts of stuff in fun ways)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

If this issue is about a bug that still happens in the latest version, or a suggestion that is still relevant, feel free to comment on it and the maintainers will have another look, they might have missed it!

Thank you!