search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

Yande.re search fails providing correct results when using correct credentials #1473

Closed bgilc closed 2 years ago

bgilc commented 6 years ago

Bug description

Yande.re search fails when using correct credentials.

Steps to reproduce

  1. As a source choose yande.re
  2. In options of the yande.re sources enter your valid login credentials.
  3. Search some tag/tags.
  4. Searching the tag/tags returns bad results (it treats the search as if you didn't enter any tags).

Expected behavior

Search should return the only posts which feature tags selected by the user.

Context

[14:22:59.103][Info] Temp directory purged of 0/0 files (0 failed) [14:22:59.764][Info] New session started. [14:22:59.765][Info] Software version: 6.0.6. [14:22:59.765][Info] Path: C:/Program Files/Grabber [14:22:59.765][Info] Loading preferences from C:/Users/sion/AppData/Local/Bionus/Grabber/settings.ini [14:23:00.976][Info] SSL libraries: OpenSSL 1.0.2k 26 Jan 2017 [14:23:00.995][Info] Setting language to 'English'... [14:23:00.996][Info] 17 sources found: anime-pictures.net (Anime pictures), behoimi.org (Danbooru), chan.sankakucomplex.com (Sankaku), danbooru.donmai.us (Danbooru (2.0)), derpibooru.org (Booru-on-rails), e621.net (Danbooru), gelbooru.com (Gelbooru (0.2)), hijiribe.donmai.us (Danbooru (2.0)), idol.sankakucomplex.com (Sankaku), konachan.com (Moebooru), rule34.paheal.net (Shimmie), rule34.xxx (Gelbooru (0.2)), safebooru.org (Gelbooru (0.2)), sonohara.donmai.us (Danbooru (2.0)), tentaclerape.net (Shimmie), www.zerochan.net (Zerochan), yande.re (Moebooru) [14:23:01.027][Info] Updating checkboxes. [14:23:01.030][Info] Updating checkboxes. [14:23:01.034][Info] Monitoring starting [14:23:01.072][Info] Monitoring tick [14:23:01.073][Info] Monitoring finished [14:23:04.196][Warning] [Qt][default] libpng warning: iCCP: known incorrect sRGB profile [14:23:11.289][Info] Loading results... [14:23:11.291][Info] [yande.re][Html] Loading page https://yande.re/post/index?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos [14:23:11.292][Info] [yande.re][Xml] Loading page https://yande.re/post/index.xml?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos [14:23:11.678][Info] [yande.re][Xml] Receiving page https://yande.re/post/index.xml?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos [14:23:11.692][Info] [yande.re][Xml] Parsed page https://yande.re/post/index.xml?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos: 40 images (40), 0 tags (81), 398189 total (398189), 19910 pages (19910) [14:23:11.802][Info] [yande.re][Html] Receiving page https://yande.re/post/index?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos [14:23:11.816][Info] [yande.re][Html] Parsed page https://yande.re/post/index?login=CryFleuret&password_hash=redacted&limit=20&page=1&tags=infinite_stratos: 40 images (40), 25 tags (25), -1 total (199100), 9955 pages (9955)

System information

Additional context Tried clean install. Same thing. According to the log password hash isn't used. It pastes the password in plain text.

bgilc commented 6 years ago

Hm. It appears it's working when I'm using the api key as password. Or maybe it doesn't. When I use clearly wrong credentials it works also...

Bionus commented 6 years ago

Is there any documentation about the usage of the API key with the yande.re API? All I found is this which only mentions user/password_hash combinations.

And in that case, have you tried using your username and password hash in the "credentials" tab?

The problem of "no results" is that your API key must contain some special characters, breaking the URL, and Grabber didn't really expect that. I should fix that actually.

According to the log password hash isn't used. It pastes the password in plain text.

You have to click the "Hash" button in the "credentials" tab, put your password there, and the program will hash the password at that time (see the documentation).

Hm. It appears it's working when I'm using the api key as password. Or maybe it doesn't. When I use clearly wrong credentials it works also...

What do you mean "works"? AFAIK the yande.re API does not require authentication for browsing, so yeah it's not even necessary to provide credentials to use it.

bgilc commented 5 years ago

You have to click the "Hash" button in the "credentials" tab, put your password there, and the program will hash the password at that time (see the documentation).

Yande.re source doesn't have the Hash button in credentials.

What do you mean "works"? AFAIK the yande.re API does not require authentication for browsing, so yeah it's not even necessary to provide credentials to use it.

Works = I get valid results. Doesn't work = Not valid results, basically it's like simply browsing into https://yande.re/post without entering any tags.

To be honest I've entered login/password simply because: "Hey, it should work."

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

If this issue is about a bug that still happens in the latest version, or a suggestion that is still relevant, feel free to comment on it and the maintainers will have another look, they might have missed it!

Thank you!