search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.48k stars 216 forks source link

Not loading any images by favorites #1488

Closed MrAndre96 closed 5 years ago

MrAndre96 commented 5 years ago

Bug description

When I was checking out this feature I saw that a lot of sources don't show images while it says that it has results while others do show results.

Steps to reproduce

Add for example the azur_lane tag to favorites Now go to the favorite page and enable for example to following sources: danbooru, gelbooru, konachan, rule34 and sankaku complex When you now go to the page you will see that only sankaku complex show images while the others just say the amount of images there are and the amount of pages.

Expected behavior

Also show the images

Screenshots

https://i.imgur.com/L5l8Id3.png

System information

Windows 10 with the latest nightly version

Bionus commented 5 years ago

It is indeed a but with the way image count is shown: those sources indeed have images, but they were all filtered because they were too old (older than the favorite's "last viewed" value).

Sources that do not provide date information, such as Sankaku Complex, or Shimmie-based boards, are the only ones with results.

I'll push a fix to properly show the reason why no images are shown.

MrAndre96 commented 5 years ago

@Bionus When I checked the details by sankaku complex or rule34.paheal.net I do see a date

Bionus commented 5 years ago

Yes, if you open the image, then check the details, because opening the image will load missing information from the https://chan.sankakucomplex.com/post/show/ID page. When you're in the image list, if you hover a thumbnail, you'll see there is no date information. Grabber could load details for images to find their creation date, but that'd be very resource-heavy (even with a dichotomy).